Bug 175221 - picasawebexport zip pb always activated
Summary: picasawebexport zip pb always activated
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Google (show other bugs)
Version: unspecified
Platform: Mandriva RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-15 15:00 UTC by Philippe ROUBACH
Modified: 2018-03-23 11:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.3.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe ROUBACH 2008-11-15 15:00:50 UTC
Version:           0.1.7 (using KDE 3.5.9)
OS:                Linux
Installed from:    Mandriva RPMs

Mandriva 2008.1
kde 3.5.9
digikam 9.5b1
kipi-plugins 0.1.7(svn)

in the template there is no availability to unactivate zip operation
then
if i have a 959 KB original picture

with 85 i get a 350 KB picture
with 0           30
with 99 i get   1158

no mean to upload the original picture in the contrary of Picasa software
Comment 1 caulier.gilles 2008-12-08 08:55:07 UTC
Jain,

What's is zip for picasaweb ?

Gilles Caulier
Comment 2 Philippe ROUBACH 2009-01-29 14:11:07 UTC
Mandriva 2008.1
kde 3.5.9
digikam 9.5b3
kipi-plugins 0.1.7

now there is a check box "resize"

i did not check "resize"

result : my still 1,2 MB is resized to 902 kB !
Comment 3 Luka Renko 2009-03-22 21:18:55 UTC
I can confirm this by reviewing the code: image is always rewritten with appropriate image quality and not uploaded as-is if no resize is specified.

From picasawebtalker.cpp:

    if (rawFilesExt.toUpper().contains(fileInfo.suffix().toUpper()))
        KDcrawIface::KDcraw::loadDcrawPreview(image, photoPath);
    else
        image.load(photoPath);

    if (!image.isNull())
    {
        path = KStandardDirs::locateLocal("tmp", QFileInfo(photoPath).baseName().trimmed() + ".jpg");

        if (rescale && (image.width() > maxDim || image.height() > maxDim))
            image = image.scaled(maxDim, maxDim, Qt::KeepAspectRatio, Qt::SmoothTransformation);

        image.save(path, "JPEG", imageQuality);
Comment 4 Luka Renko 2009-03-22 21:58:48 UTC
SVN commit 942897 by lure:

Do not rewrite photos to temporary file before upload if no resize was 
selected by user. Only need temporary file if resize was requested and
for extraction of preview image from RAW.

BUG: 175221


 M  +3 -2      NEWS  
 M  +28 -16    picasawebexport/picasawebtalker.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=942897