Version: (using KDE 4.1.2) Installed from: Ubuntu Packages See this bug: https://bugs.kde.org/show_bug.cgi?id=133995 You've managed to reintroduce this again in kde4. The patch I wrote last time didn't touch the parser at all, it just sorted the strings by length before matching, so the longest string would be matched first, that way matching would always be greedy.
Created attachment 28323 [details] nongreedy matching of emoticons
This is actually a kdelibs issue not a kopete issue. The kopete team seems to ignore these bugs. Try to reassign it.
Trying to reassign.
Created attachment 30015 [details] Makes emoticon parsing check largest emoticons first by sorting them If emoticons.xml is laid out in such a manner that the largest emoticons come first, the patch is unneeded. However, having to sort emoticons.xml is pointless and should be handled in the code. This makes it easier to port other emoticon sets to KDE and kopete
The patch will no longer be maintained.
ok, i'm a bit confused by what the actual problem is. Should we be sorting the emoticons? Should the matching be non-greedy? greedy? I'm happy to fix this bug, but I need more information to determine the proper fix. Thanks.
Simply the issue is that it since its not greedy it doesn't recognize emoticons correctly. If :- is in the list before :-) is it will display the emoticon for :- when :-) is typed. One can overcome this by sorting the emoticon list by size in descending order when the list is loaded. There are several other complaints about this. the filers just didn't know what was happening. FYI the patch worked up through 4.2, it just needs cleaned up to fit the KDE style.
SVN commit 947655 by mattr: Fix bug 174262. Sort emoticons when tokenizing so the matching works better than when the list is unsorted. Patch by Timothy Knoll. Thanks! CCBUG: 174262 M +16 -0 kemoticonstheme.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=947655
SVN commit 947656 by mattr: Backport patch for bug 174262. This should be in KDE starting with KDE 4.2.3 BUG: 174262 M +16 -0 kemoticonstheme.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=947656
bug 118624 is a duplicate.
*** Bug 118624 has been marked as a duplicate of this bug. ***