Bug 174259 - emoticon theme stopped working
Summary: emoticon theme stopped working
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Ubuntu Unspecified
: NOR normal
Target Milestone: ---
Assignee: Carlo Segato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-04 15:15 UTC by Martin Matusiak
Modified: 2009-01-09 12:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
the emoticon theme in question (203.97 KB, application/x-gzip)
2008-11-04 15:18 UTC, Martin Matusiak
Details
same file, but "theme" missing, loads okay (203.20 KB, application/x-gzip)
2008-11-04 15:25 UTC, Martin Matusiak
Details
load failed screenshot (31.73 KB, image/png)
2008-11-04 15:26 UTC, Martin Matusiak
Details
load ok screenshot (45.18 KB, image/png)
2008-11-04 15:26 UTC, Martin Matusiak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Matusiak 2008-11-04 15:15:53 UTC
Version:            (using KDE 4.1.2)
Installed from:    Ubuntu Packages

I maintain an emoticon theme that works with a lot of different clients. Unfortunately, every client has a different format for the definition file, so what I do is zip the images and put all the various definition files in there too, each client will then find the file it's looking for, including kopete.

As of kopete-kde4, or kde-4.1.2, which is where I first found the bug, the emoticon set can no longer be loaded correctly. I've looked at how emoticons are defined in kde4 and the format seems to have changed. I can produce an emoticons.xml file that fits the bill, but the theme is still not loaded correctly.

What I suspect is that pidgin's "theme" file is found and read first. Unfortunately, the result is epic fail (it loads correctly in pidgin, obviously), what I get in the gui is an empty list. If I delete this file, kopete presumably finds emoticons.xml (or maybe icondef.xml, who the heck knows) and does load the set correctly.
Comment 1 Martin Matusiak 2008-11-04 15:18:56 UTC
Created attachment 28319 [details]
the emoticon theme in question

The purpose of this file is to be loaded and work in as many different clients as possible. Verified to work in kopete (kde3), gaim, gajim, psi.

As you'll find, it also contains the scripts I use to generate these definition files.
Comment 2 Martin Matusiak 2008-11-04 15:25:20 UTC
Created attachment 28320 [details]
same file, but "theme" missing, loads okay
Comment 3 Martin Matusiak 2008-11-04 15:26:03 UTC
Created attachment 28321 [details]
load failed screenshot
Comment 4 Martin Matusiak 2008-11-04 15:26:26 UTC
Created attachment 28322 [details]
load ok screenshot
Comment 5 Martin Matusiak 2009-01-08 15:01:16 UTC
Trying to reassign.
Comment 6 Carlo Segato 2009-01-09 00:34:52 UTC
SVN commit 907952 by segato:

sort the kemoticons provider by priority so if we have multiple theme file we will use the provider with higher priority(in this case the kde one)
CCBUG: 174259


 M  +6 -0      kemoticons.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907952
Comment 7 Carlo Segato 2009-01-09 00:37:37 UTC
SVN commit 907953 by segato:

use a qregexp to split the line since we can have tabs instead of spaces
BUG: 174259


 M  +1 -1      pidgin_emoticons.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907953
Comment 8 Martin Matusiak 2009-01-09 12:17:54 UTC
Excellent! Any chance this might get snuck into KDE 4.2? :)
Comment 9 Carlo Segato 2009-01-09 12:28:39 UTC
yeah it's already fixed in the 4.2 branch too