Bug 173166 - konsole has two Bookmarks menus
Summary: konsole has two Bookmarks menus
Status: CLOSED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-19 22:29 UTC by Stefan Usenbinz
Modified: 2009-01-18 12:08 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Fix for this issue; tested with before broken apps. (786 bytes, patch)
2008-12-29 22:17 UTC, Urs Wolfer 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Usenbinz 2008-10-19 22:29:28 UTC 
Version:            (using Devel)
Compiler:          gcc-Version 4.2.4 (Ubuntu 4.2.4-1ubuntu3) 
OS:                Linux
Installed from:    Compiled sources

konsole from trunk has two Bookmarks menus.

- The first (left on the menubar) one is the KActionMenu created in kdebase/apps/konsole/src/MainWindow.cpp:253 and has four entries: 
-- Add Bookmark
-- Bookmark Tabs as Folder...
-- New Bookmark Folder...
-- Edit Bookmarks

- The second one comes from /kdelibs/kdeui/xmlgui/ui_standards.rc and has two entries:
-- Add Bookmark
-- Edit Bookmarks

Both "Add Bookmark" entries cause a menu entry to be added to the first menu. Also both "Edit Bookmarks" entries edit the same set of bookmarks.

Seems the manual creation of the menu conflicts with the standard setup (btw.: I verfied that the two menus indeed come from those locations by editing the menu titles in the two files mentioned).

kdebase SVN Revision: 873271
kdelibs SVN Revision: 873263
Comment 1 Dario Andres 2008-12-04 15:57:44 UTC 
I can confirm this in KDE4.2svn (kdelibs rev. 892368/  kdebase rev.892400 ) in ArchLinux x86_64
Comment 2 Will Angenent 2008-12-08 01:05:58 UTC 
I can confirm this too.
Comment 3 Gustavo Narea 2008-12-15 17:32:27 UTC 
I can also confirm this bug with Kubuntu packages (KDE 4.2 Beta 1).
Comment 4 Dario Andres 2008-12-15 21:36:08 UTC 
Confirming here using:

Qt: 4.4.3
KDE: 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2))
kdelibs svn rev. 896844 / kdebase svn rev. 896844
Comment 5 Vlad Adamenko 2008-12-17 12:58:16 UTC 
I confirm this bug.

Konsole 2.2
KDE: 4.1.80
Comment 6 Michal Ziabkowski 2008-12-18 21:20:24 UTC 
Happens here too.

KDE 4.1.85
Comment 7 Alvin 2008-12-23 15:21:57 UTC 
krdc has the same problem. Maybe the bug can be found in kbookmarks and not in konsole?
Comment 8 Stefan Usenbinz 2008-12-23 16:48:47 UTC 
Indeed. krdc uses a similar combination of XML GUI and manually created Action / KBookmarkManager.
Comment 9 Stefan Usenbinz 2008-12-23 17:41:23 UTC 
Found another one. KBugBuster uses similar implementation and has the same problem.
Comment 10 Urs Wolfer 2008-12-29 22:17:07 UTC 
Created attachment 29744 [details]
Fix for this issue; tested with before broken apps.

I will commit this fix soon if noone objects. Seems to fix the issue.
Comment 11 Stefan Usenbinz 2008-12-30 15:48:23 UTC 
Looks good to me. With patch applied konsole, krdc, kbugbuster and kjots now look good. Also okular and konqueror (which also use kbookmarks and xml gui, but somewhat differently and did now show the problem before) still look good. krdc's "History" sub-menu looks somewhat strange since it seems to mirror the main bookmark menu (Add Bookmark, New Bookmark Folder etc.), but that is unrelated to the patch.
Comment 12 Urs Wolfer 2008-12-30 22:41:02 UTC 
SVN commit 903567 by uwolfer:

Fix issue that many apps had two bookmark menus.
BUG:173166

 M  +2 -7      ui_standards.rc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903567
Comment 13 Friedrich W. H. Kossebau 2008-12-31 03:56:10 UTC 
Grml. This commit broke Okteta, which used just XMLGUI...
Comment 14 Urs Wolfer 2008-12-31 12:55:09 UTC 
FYI: this issue will no be discussed on k-c-d: "Re: KDE/kdelibs/kdeui/xmlgui".
Comment 15 Stefan Usenbinz 2009-01-18 12:08:33 UTC 
Ultimately fixed with 904594.