Bug 172911 - Album File lister does not have an "All Image FIles" filter.
Summary: Album File lister does not have an "All Image FIles" filter.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Filters (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-16 04:03 UTC by Joe Biden
Modified: 2012-06-27 11:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.10.0
Sentry Crash Report:


Attachments
Album lister (777 bytes, patch)
2008-10-16 04:04 UTC, Joe Biden
Details
mimefilter.h (301 bytes, patch)
2008-10-16 04:05 UTC, Joe Biden
Details
mimefilter.cpp (948 bytes, patch)
2008-10-16 04:05 UTC, Joe Biden
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Biden 2008-10-16 04:03:05 UTC
Version:            (using Devel)
Installed from:    Compiled sources

I often have video and audio files in the same directory as my images. Very rarely do I want to see these in my Digikam Album view, so this patch should show only the other selectable Image types. This should probably pull the setting from the "Supported File Types" setting.
Comment 1 Joe Biden 2008-10-16 04:04:46 UTC
Created attachment 27924 [details]
Album lister
Comment 2 Joe Biden 2008-10-16 04:05:19 UTC
Created attachment 27925 [details]
mimefilter.h
Comment 3 Joe Biden 2008-10-16 04:05:46 UTC
Created attachment 27926 [details]
mimefilter.cpp
Comment 4 Andi Clemens 2008-10-21 00:00:07 UTC
If you never use video and audio in digiKam, you can also remove the mimetypes in the settings dialog.

Gilles and others,

what do you think of the patch? Do we need it?

Andi
Comment 5 caulier.gilles 2008-10-21 09:41:06 UTC
Andi,

Why not. But the action title from combo box filter must be "Image Files" to be homogenous with other actions.

Gilles Caulier
Comment 6 Andi Clemens 2008-10-21 10:25:52 UTC
The quickfilter for image types isn't working at all at the moment. For example choose "JPEG" or "No RAW", for me the indicator lamp is always red.
We need to fix this first before applying these patches.

Andi
Comment 7 Andi Clemens 2008-10-21 11:18:43 UTC
This is strange, I guess I found out why most of the mimetype filters are not working:
I tested it with a root album that contains images directly, no subfolders.
I have two root album paths, one with unimportant images to test digiKam 0.10 and one from my current collection from KDE3 that contains RAW files etc to play with.
My structure is as follows:

/mnt/data/fotos/digiKam tests 	=>	(root1)
/home/andi/testfotos/					=>	(root2)
|-- 001
|-- 002
     |-- 003

etc....

So tring to filter on root1 is failing for most of the mimetypes. But why?
Audio file filter seems to be broken, I have to check that.

Gilles, Marcel,

any idea why the mimefilter is not working on a root album directly?

Andi
Comment 8 Andi Clemens 2008-10-21 11:52:53 UTC
I don't understand this, the above theory seems to be wrong, too.
Somehow some folders are working, others are not, it seems to be the same problem described in bug 162496, I guess there is a KDE or Qt problem here. But I don't know if it is related to my system only or if others are having the same problems.

Andi
Comment 9 Andi Clemens 2008-10-21 18:23:52 UTC
SVN commit 874451 by aclemens:

fix logic error so that mimetype filter for movies and audio is working again

CCBUG:172911

 M  +2 -2      albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=874451
Comment 10 Andi Clemens 2008-10-21 18:23:56 UTC
SVN commit 874452 by aclemens:

added new quickfilter type "Image Files" to display only images in icon views.

BUG:172911

 M  +7 -0      albumlister.cpp  
 M  +3 -2      mimefilter.cpp  
 M  +1 -0      mimefilter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=874452
Comment 11 Andi Clemens 2008-12-12 09:45:28 UTC
SVN commit 896004 by aclemens:

add "Image files" mime filter

CCBUG:172911

 M  +9 -1      albumlister.cpp  
 M  +9 -8      mimefilter.cpp  
 M  +1 -0      mimefilter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=896004
Comment 12 caulier.gilles 2009-01-23 21:37:48 UTC
Andi,

This file can be closed now ?

Gilles
Comment 13 Andi Clemens 2009-01-23 21:53:29 UTC
It is already closed...
Comment 14 caulier.gilles 2009-01-24 08:46:37 UTC
oups sorry (:=)))

Gilles