Bug 172836 - No menu item for lensfun
Summary: No menu item for lensfun
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-LensCorrection (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-15 01:39 UTC by Antonio E.
Modified: 2018-07-05 13:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio E. 2008-10-15 01:39:12 UTC
Version:            (using Devel)
Installed from:    Compiled sources

Using the svn of digikam 0.10.

I have lensfun installed. When compiling, cmake find lensfun and displays that the lensfun support will be compiled.

Then I go to digikam, and there's no menu item anywhere to use lensfun. I though that it should be one under the Enhace or Transform menu in the image editor.

I'm using lensfun 0.2.3.
Comment 1 Andi Clemens 2008-10-15 09:52:22 UTC
It is used in the image editor under Enhance->Lens->Auto Correction
Comment 2 Antonio E. 2008-10-15 10:04:32 UTC
Thanks Andy. I understand that should work, but for any reason it does not on my computer. I'm wondering if there's any hidden option that I have off because of having the digikamrc file created with a version that didn't had support for the plug-in. And after compiling the plugin is kept disabled.

That submenu (Lens) is what I was expecting to have under the Enhace menu in my
menu editor. But it's not there. My enhace menu has the following entries:

Sharpen
Blur
--------
Red Eye
Hot Pixels
Inpainting
Noise Reduction
Restoration

That's all. So, at compiling time apparently it's detected and used. But when I
run the application, it's like if it is not there. I've been looking in the
configure window and the digikamrc file if there's any hidden option to
enable/disable the plugin and if for any reason I have it off, but for now I
had no luck with it.
Comment 3 Andi Clemens 2008-10-15 11:09:14 UTC
That the library was found by cmake doesn't necessarily mean it is also used.
Try running
'ccmake .'
in the kdegraphics dir. There are two important vars:

LENSFUN_INCLUDE_DIR              /usr/include
LENSFUN_LIBRARY                  /usr/lib/liblensfun.so

Make sure they are set (depending on your system paths of course).
Also make sure that

WITH_LensFun                     ON

is turned on. If not, highlight this variable and hit enter to toggle the value.

Andi
Comment 4 Andi Clemens 2008-10-15 11:11:05 UTC
Note: If you changed values in this tool, hit "C" to run configure again and if everythng works fine, hit "G" to generate the new settings.
After that run cmake again, then make and make install.
Comment 5 Andi Clemens 2008-10-15 11:14:44 UTC
One more note: I just disabled lensfun and rebuild digiKam, the lens menu is still there, only auto-correction is missing. So there might be something else wrong with your setup if no lens submenu is visible at all.
Comment 6 Antonio E. 2008-10-15 15:01:58 UTC
Thank you Andi for your answers.

I have done what you said:

ccmake . in the folder and I get the following variables:

LENSFUN_INCLUDE_DIR     /usr/include
LENSFUN_LIBRARY         /usr/lib/lensfun.so
WITH_LensFun            On

So, they're set.

I have no idea about what else can make the Lens menu to not be there. Any other idea?

Thanks in advance.
Comment 7 Antonio E. 2008-10-15 15:19:31 UTC
Umm, I think that I found the answer to the problem.

It's not a digikam problem. It's a problem in the ebuild that I'm using. The guy that made the ebuild disabled the digikam support, presumably because there's no official ebuild for lensfun in gentoo yet.

I'll modify the ebuild now and test it.
Comment 8 Antonio E. 2008-10-15 15:29:29 UTC
This is the piece of code in the ebuild affecting to lensfun, in case of any other gentoo user has the same problem:

# Deactivate this, fails.
   sed -e '/lenscorrection/ s:^:#DONOTWANT :' \
       -i "${S}"/digikam/imageplugins/CMakeLists.txt \
       || die "Deactivating lensfun plugin failed."

So, obviously it was just that lensfun was disabled in Gentoo. Not a problem in digikam.

I've just recompiled and now I have the missing menu there. So, solved.

Thanks a lot for the help.
Comment 9 caulier.gilles 2018-07-05 13:06:34 UTC
With 6.0.0 all image editor tools are merged as well in editor. No plugins to load anymore == no this kind of problem...

Gilles Caulier