Bug 172458 - Readonly text fields should use "disabled" visual style.
Summary: Readonly text fields should use "disabled" visual style.
Status: RESOLVED INTENTIONAL
Alias: None
Product: Oxygen
Classification: Plasma
Component: style (show other bugs)
Version: unspecified
Platform: Ubuntu Unspecified
: NOR normal
Target Milestone: ---
Assignee: Camilla Boemann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-09 15:02 UTC by Dotan Cohen
Modified: 2011-01-13 20:43 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
UI file (1.87 KB, application/x-designer)
2011-01-12 14:38 UTC, Christoph Feck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2008-10-09 15:02:10 UTC
Version:            (using KDE 4.1.2)
Installed from:    Ubuntu Packages

In several places in KDE (for instance, Kate's bookmark manager) there are text fields that are inactive for one reason or another. These text fields should have a visual indicator that they are inactive, for instance they should be a darker colour than the active fields. See bug 166066 for confusion caused by the current situation.

Note that I file this as a Bug, and not as a Wish, because of the usability implications. I have had this issue bite me before, and it is often time consuming to figure out what is wrong.
Comment 1 Joseph Wenninger 2008-11-30 18:24:44 UTC
That's a bug in KDE's bookmark manager, I can reproduce this with trunk. If now bookmark is selected the text fields appear enabled but you can't enter anything
Comment 2 Dotan Cohen 2008-11-30 21:46:21 UTC
Although the issue mentioned in bug 166066 was specific to KDE's bookmark manager, the issue of disabled input fields being visually indistinctive from active input fields is found throughout KDE 4.
Comment 3 Matthew Woehlke 2008-12-20 02:52:38 UTC
Disabled widgets should be using disabled colors. You could check this by changing the effects for disabled widgets to something insane, like tint to red (in the 'disabled effects' tab of the color kcm). If it's not working... I'm not sure what to say, Qt is supposed to handle it.

Are you sure you're seeing /disabled/ widgets and not /read-only/ widgets?
Comment 4 Dotan Cohen 2008-12-27 00:34:21 UTC
For all intents and purposes, a /read-only/ widget is /disabled/ so far as the user is concerned: he tries to type in it and cannot. Furthermore, these /read-only/ widgets are in fact /read-write/ widgets sometimes, so the visual distinction is even more critical.

Further, furthermore, mousing over these /read-only/ widgets highlights them like any other input element.

Steps to reproduce:
1) Open Kate's Bookmark Editor
2) Create a bookmark
3) Mouse over the Location field. Try to focus the field and type in it.
Comment 5 Matthew Woehlke 2009-01-24 03:00:14 UTC
You can't select text in disabled widgets. Ergo, read-only != disabled. (But maybe it should be?)

Since this affects many parts of KDE, you might want to first check if there is already an HIG guideline regarding this, and if not, ask on kde-usability about it (maybe we should write one?). Then when there is consensus what is "correct" behavior, bugs should be filed against specific apps that violate the guideline.
Comment 6 Dotan Cohen 2009-01-27 17:00:25 UTC
This bug is not about selecting text. The bug is about a widget that looks [active|enabled|working] but is not.
Comment 7 Christoph Feck 2009-12-09 06:40:44 UTC
While this "bug" may show with many styles, the behavior can actually be controlled by the style, i.e. it can render read-only line edits to look disabled. Reassigning to Oxygen.

It may have to be discussed with artists and usability team if a change can be made here.
Comment 8 Hugo Pereira Da Costa 2011-01-12 12:32:02 UTC
in fact, this bug is invalid.
Specific examples should be provided (in different bugs) whenever this situation occurs. 

Oxygen do draw disabled text whenever it is asked to. When this is not the case, its usually an upstream bug and not oxygen's. Closing as invalid. Awaiting for detailed bugs of this sort if there are some.
Comment 9 Christoph Feck 2011-01-12 14:38:14 UTC
Created attachment 55912 [details]
UI file

Hugo, please read the bug carefully. This bug is about read-only line edits, not about disabled widgets. There is no visual indication that you cannot enter text (not that any other style has one ...)
Comment 10 Hugo Pereira Da Costa 2011-01-12 14:45:02 UTC
Cristoph, as far as I recall, there is an indication: there is no cursor.
In my opinion there should be no other indication (and especially not a "disabled" look), since as was pointed out in the bug (which I did read) you however can select the text, copy it to clipboard, etc.

Besides, this issue is not what the bug title refer to.
Comment 11 Hugo Pereira Da Costa 2011-01-12 15:01:30 UTC
Also, for QLineEdit at least, the mouse pointer does not change shape (to edition pointer) when passing over a read-only widget. Thats another strong indication I believe. This is not the case for QTextEdit, but that's not oxygen's fault. 

I was thinking of disabling the (keyboard) focus glow for read-only editors, but it turns out this also would be incorrect 
1/ because you can still put the focus on such widgets
2/ you can actually select text using keyboard navigation in the editor.

So really, this part of the bug would also be invalid, in my oppinion.
Comment 12 Dotan Cohen 2011-01-13 20:09:45 UTC
I updated the title to reflect the nature of the bug. A readonly text field should be visually similar (if not identical) to a disabled field, and _not_ visually similar to a read/write field. Changing the mouse indicator or the presence of a cursor does not help the user who is not mousing over. Also, the changing mouse indicator is not noticed by regular users, and it is quite the lack of a cursor that makes users feel that something is not working when it should.

Shall I post explicit screenshot of how other environments (Mac, Windows, Gnome) handle readonly text fields?

Thanks.
Comment 13 Hugo Pereira Da Costa 2011-01-13 20:28:23 UTC
@Dotan,
First, thanks for changing the title to make it more explicit.
However I still consider the bug as invalid and won't fix.
The arguments are already stated above but let me restate
1/ there are already visible differences for readonly editors and editable ones. You dim them insufficient, but i disagree.

2/ readonly editors can get keyboard focus whereas no disable widget can. This in itself close the debate, as far as I am concerned.

3/ Many readonly *text* (multi-line) editors have no distinction between read-only and editable, on all OS's, and should stay so. Example include: kmail's message view (which is read-only) konqueror's main HTML viewer, any text-editor opening a read-only file etc, konversation (or kopete) message logs, etc. Oxygen (and me) makes no conceptual difference between single and multi line editor, so will not change their apearance of the latter, for consistency with the former. 

Since you don't seem happy with INVALID (though to me, it is, because of point 2), I'm closing as WONTFIX.
Comment 14 Dotan Cohen 2011-01-13 20:36:31 UTC
The example places that you state (Kmail's message view, Konqueror's main HTML viewer) do not have the same visual appearance that do editable text fields. The root of this issue is text fields that _do_ appear to be read/write, and that a user would reasonably expect to be, but are not. Please see this bug for the confusion that the issue causes:
https://bugs.kde.org/show_bug.cgi?id=166066
Comment 15 Hugo Pereira Da Costa 2011-01-13 20:38:31 UTC
PS: re-reading previous post I realize that my english is far from perfect.
I guess I've typed too quick, and its been a long day. Sorry ...
Comment 16 Hugo Pereira Da Costa 2011-01-13 20:43:21 UTC
mmm. They do (all but konqueror) have the same appearance in oxygen. Sunken frame with shadow, with white background, and glow with different colors with mouse over and keyboard focus.

An explicitely disabled lineeditor would do none of the above.
For the bug you mention, I would suggest that the application explicitely disable the widget, as long as it wants it disabled.

As mentionned by my point 2 above, a read-only editor *is not* a disabled editor.
Comment 17 Dotan Cohen 2011-01-13 20:43:33 UTC
That's alright, I understand you even if we disagree! You should see my own English when the coffee runs out... in any case, it's late here so Buenos Noches until tomorrow...