Bug 171312 - Jewish Holidays Do Not Diplay
Summary: Jewish Holidays Do Not Diplay
Status: RESOLVED UNMAINTAINED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Unspecified
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-19 10:56 UTC by eli
Modified: 2017-01-07 22:39 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Outlook options (31.58 KB, image/png)
2010-05-29 15:31 UTC, John Layt
Details
Outlook holidays (13.66 KB, image/png)
2010-05-29 15:31 UTC, John Layt
Details
Outlook month view (70.87 KB, image/png)
2010-05-29 15:32 UTC, John Layt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description eli 2008-09-19 10:56:39 UTC
Version:            (using KDE 4.1.1)
Installed from:    Fedora RPMs

In kdepim 4.1.1 and korganizer, and after the Jewish Holidays plugin is enabled, the holidays do no appear in the calendar.
Comment 1 Allen Winter 2008-09-20 16:09:30 UTC
Works for me.
First go into Configure Calendar -> Plugins page
Select Jewish Calendar Plugin
Then make sure to select one of the Position options, for me
I select "show at the top of agenda views"

You might also want to see them in the month view.

The bug is that at  some of those Position options should be set by default.
So I won't close this bug until we set sane Position defaults.
Comment 2 eli 2008-09-20 18:46:43 UTC
OK... I see it in the agenda view. But, I do not see it in the monthly view.
Comment 3 eli 2008-10-10 07:06:30 UTC
Problem persists in 4.1.2
Comment 4 eli 2008-11-16 08:58:59 UTC
Problem persists in 4.1.3
Comment 5 eli 2008-12-12 09:09:07 UTC
Problem persists in 4.1.8
Comment 6 Allen Winter 2008-12-15 20:34:48 UTC
Update: I've been playing around with putting the Jewish dates in the month view.  and I can't make it look nice.

i'm confused though.. this plugin seems to overlay the entire Hebrew calendar, so a lot more than just the Jewish holidays get put on the calendar.

Should we add an option to the plugin to show only the holidays, and not the entire Jewish calendar?  

I think we should have the Jewish holidays looking like any other holiday would in the monthview.  overlaying an entire second set of dates from another calendar system is a totally different problem we need to consider, at least in the month view.

comments?
Comment 7 eli 2009-01-16 10:39:17 UTC
Problem persists in 4.1.96
Comment 8 Allen Winter 2009-01-16 23:49:22 UTC
Eli,

In what way does the problem persist?  I know that the Jewish holidays do not show up in the monthview.. but I asked you for advice on how to handle some issues in Comment #6.

I am waiting for your response to my questions before proceeding.

Or is there something else going on here that I don't understand?
Comment 9 eli 2009-01-17 06:19:58 UTC
Ooops... Sorry... I don't know how I could have misunderstood such a simple straight forward request. Please forgive me.

>> Should we add an option to the plugin to show only the holidays,
>> and not the entire Jewish calendar? 

I think that is correct. Approach. And if possible, if the holiday is placed in the calendar like any other event, then any of the other relevant info that is already recorded with the holiday be placed inside the event (maybe in the description section). Maybe even a link to a wiki like wikepedia would be a really cool feature (I realize that that would be a lot of work - Just a thought though).

One other thing.... If possible... Since the a day in the Jewish Calendar begins after sunset and ends at sunrise, it would also be very cool if a Jewish Holiday event would span at least the half day of each day to give a visual indication of that. Maybe its just me, but when work gets really really hectic my "dyslexia" shows up and I get confused as to when the event actually occurs. I think this as a feature would be really really nice touch.

>> overlaying an entire second set of dates from another calendar system
>> is a totally different problem we need to consider.

I agree that this is a problem, but not one that you can have any control over. How would you know that an imported event is a holiday or not unless its marked someway as a holiday. Or you do a brute force match.

If you have someway to detecting whether an imported event is a holiday then it would be good to ask the user if the event should be imported. And if so, then import the event as faithfully as you possibly can and leave the esthetics to the user.
Comment 10 eli 2009-01-30 06:29:40 UTC
I know you know. Just making it formal :) Problem persists in 4.2.
Comment 11 Shai 2009-03-04 19:16:20 UTC
In Israel, we always use Hebrew numerals for the Hebrew dates. Thus, as today, March 4, is 8 Adar, the square for today would say something like "4 ח" (I hope you can see this character -- it's "Het", the 8th letter in the Hebrew alphabet). 

This is normally not done abroad, though, so I suspect this cannot solve everything; but at least for use in Israel, it has to be part of the solution (and when this is done, I think the month names should also be in spelled in Hebrew, regardless of locale).

In like spirit, I think that if we want to overlay another calendar on the month view, I think we should use a visual distinction (a lot like the colors for different resources). This solution may also be extensible to more than two calendars (I'm not aware of many other places where this makes sense, but some Israelis want to access not just the Gregorian and Hebrew calendars, but also the Hegira [Muslim] calendar).
Comment 12 eli 2009-03-04 20:57:15 UTC
Hi Shai.

I think the always display Hebrew would be a nice feature. But I for one would like to read the stuff in English because my Hebrew is abysmal.

In regards to different colors for different calendars. I think the best choice would be to be able to select which calendar you would want to see. Because, in Israel I can envision a situation were a user would want to view the Hebrew, Muslim, Gregorian and Greek Orthodox calendar all at the same time. That would be truly a nightmare. For the user; making heads or tails of whats what. For the programmer; to lay everything out in some kind of coherent fashion.

Mind you if enough users wanted such a feature it would make an interesting usability study.

Just my 2 אגורות worth of comment.
Comment 13 Dj YB 2009-08-18 12:03:40 UTC
I might misunderstood the problem, I'm using 4.2.4 and the Jewish dates are showing up in the agenda view using the plugin, and so are the holidays, so why can't they just show up in the month view, same as they show in the agenda view...
and little correction to comment #9, Jewish days and religious holidays begin and end in sunset, the first half from the sunset to midnight prefixed with "Erev" (evening) and the second half from midnight to sunset sometimes prefixed with "Yom" (day) but it's mostly unnecessary since the word "Yom" is sometimes part of the holiday name. (Yom Kipur, Yom Haatzmaut, Yom Yerushalaim, ...)

and showing several regional holidays is a must in Israel, and probably a good feature everywhere if you want to prepare for many gifts or employees shortage...
Comment 14 John Layt 2010-05-29 15:31:03 UTC
Created attachment 47456 [details]
Outlook options
Comment 15 John Layt 2010-05-29 15:31:41 UTC
Created attachment 47457 [details]
Outlook holidays
Comment 16 John Layt 2010-05-29 15:32:18 UTC
Created attachment 47458 [details]
Outlook month view
Comment 17 John Layt 2010-05-29 15:32:30 UTC
To summarise my understanding of this particular bug, the month view does not display the Jewish plugin calendar decoration, but the other views do.  The main problem seems to be that by having both the Jewish date and Jewish holidays in the same decoration provided by the Jewish plugin, the decoration is just too big for the month view.  Clearly these need to be separated.

There's actually a number of generic issues around alternative calendar systems in KOrganizer that need to be addressed separately:

* Display a second calendar system in all views and chose what language it displays in
* Recurrences calculated using alternative calendar systems
* Birthdays counted in alternative calendar systems
* Define holidays in KHolidays using alternative calendar systems (done in 4.5!)
* Select multiple holiday regions to be displayed

So, the holidays problem should be mostly solved with 4.5 by migrating the Jewish holidays into KHolidays, which leaves the second calendar view problem for 4.6, then we can deprecate the plugin :-)

Outlook is the only software I know that already supports this, see attached pictures.  Taking it one step further, I see us having settings for Primary and Secondary calendar systems.  The Primary sets the main UI system (usually the locale one), the Secondary sets an optional system to display.  Each view then implements the Secondary as best suited for that view, in the case of month view just add the date in the day cell header or in a separate box on the bottom of the day cell.
Comment 18 eli 2010-05-29 19:00:35 UTC
Thanks for your attention to this
Comment 19 Denis Kurz 2016-09-24 18:43:17 UTC
This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of korganizer (version 5.0 or later, as part of KDE Applications 15.08 or later), it gets closed in about three months.
Comment 20 Denis Kurz 2017-01-07 22:39:09 UTC
Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input.