Bug 171072 - winpopup protocol doesn't sees hosts without description
Summary: winpopup protocol doesn't sees hosts without description
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: WinPopup Plugin (other bugs)
Version First Reported In: 0.60.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-14 20:12 UTC by Christian Morales Vega
Modified: 2013-06-05 08:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Morales Vega 2008-09-14 20:12:14 UTC
Version:           0.60.1 (using KDE 4.1.1)
OS:                Linux
Installed from:    SuSE RPMs

I am not a QT developer, but libwinpopup.cpp has the line: "QRegExp group("Workgroup\\|(.[^\\|]+)\\|(.+)"), host("Server\\|(.[^\\|]+)\\|(.+)")"

The thing is smbclient output can be like this:
Server|PRIMERO|fdf
Server|R2D2|
if "R2D2" doesn't specifies a description. In such a case looks like kopete doesn't sees it (I don't have control over R2D2 to verify).

So I think the last "\\|(.+)" in the regular expression should be something like "\\|(.*)". Probably the same in all the others regexps.
Comment 1 Christian Morales Vega 2008-09-15 19:19:06 UTC
OK, I verified it.
If my machine hasn't a description (server string) Kopete says I'm not connected to the winpopup network.
Machines without description can't be added like contacts.
Both are fixed after adding a description.

Between, could not libsmbclient be used for everything but the reception of messages? I haven't found API doc, but http://websvn.kde.org/trunk/KDE/kdebase/runtime/kioslave/smb/ could help?
Comment 2 Pali Rohár 2013-06-05 08:08:17 UTC
This bug was fixed in KDE 4.4.