Version: (using KDE 4.1.1) OS: Linux Installed from: SuSE RPMs As in subject. Does work with FF and IE. I'm pretty sure this is due to svn revision 851859 because it has worked before appling it (on kde 3.5.9). Attached the testcase. thanks, Andrea.
Created attachment 27337 [details] testcase zipped testcase folder
Thanks for the great report + testcase. The below should fix it... It wasn't accepting some shorthands with only a single background position specified since parseBackgroundPositionXY was setting position kind to non-keyword even when it wasn't a position. Oops. Index: css/cssparser.cpp =================================================================== --- css/cssparser.cpp (revision 854506) +++ css/cssparser.cpp (working copy) @@ -1500,10 +1503,12 @@ } return new CSSPrimitiveValueImpl(percent, CSSPrimitiveValue::CSS_PERCENTAGE); } - kindOut = BgPos_NonKW; - if (validUnit(valueList->current(), FPercent|FLength, strict)) + + if (validUnit(valueList->current(), FPercent|FLength, strict)) { + kindOut = BgPos_NonKW; return new CSSPrimitiveValueImpl(valueList->current()->fValue, (CSSPrimitiveValue::UnitTypes)valueList->current()->unit); + } return 0; }
Fixed by: http://lists.kde.org/?l=kde-commits&m=122100486929474&w=2 Thanks again for the great report.
.. and regression test in: http://lists.kde.org/?l=kde-commits&m=122100511129736&w=2
Created attachment 27345 [details] testcase2 Thank you for the quick fix! I applied it and works fine (only on kde 3.5.9, i have no way to test on kde 4.1). I have a second test case that worked before revision 851859 and the last patch doesn't fix; Konqueror show blank page, not the case of IE,FF. Sorry not able to test on kde 4.1.1 (...at the moment). Cheers
Forget last comment: my mistake. Sorry for that.