Bug 169963 - attachments displayed in headers should open the attachement
Summary: attachments displayed in headers should open the attachement
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: messageviewer (show other bugs)
Version: 1.10.0
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-28 07:23 UTC by Kishore
Modified: 2008-08-29 18:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore 2008-08-28 07:23:42 UTC
Version:           1.10.0 (using 4.1.62 (KDE 4.1.62 (KDE 4.2 >= 20080814)), compiled sources)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-21-generic

When kmail displays the attachments name in the mail header, clicking it currently scrolls the mail to the lower end where the attachments are shown. IMHO, clicking it should open the attachment rather than scroll the mail body.

With a long mail the current action is often evident because the user see the mail body scroll to the bottom when he/she clicks on the attachment name. Other times when the body of the mail is short and does not require scrolling, clicking on the attachment seemingly does nothing. I would consider this a usability bug.
Comment 1 Thomas McGuire 2008-08-28 13:43:08 UTC
Actually, it does that for me in the current trunk version, when clicking an attachment KMail displays the "Open" dialog.
Comment 2 Jonathan Marten 2008-08-28 19:07:18 UTC
Confirmed fixed in trunk by r851797, but not in 4.1 branch.
Close as FIXED for KDE4.2, WONTFIX for earlier?
Comment 3 Thomas McGuire 2008-08-28 19:12:45 UTC
> Confirmed fixed in trunk by r851797, but not in 4.1 branch.
> Close as FIXED for KDE4.2, WONTFIX for earlier?

4.1 doesn't have attachments in headers at all I think, right?

Seems like I fixed this in r851797 by accident actually.
Makes me wonder where the scrolling code is, I should probably remove that...
Comment 4 Jonathan Marten 2008-08-28 21:20:38 UTC
There isn't any scrolling code, it's done with named HTML anchors.
See 3rd diff section of http://websvn.kde.org/trunk/KDE/kdepim/kmail/kmreaderwin.cpp?r1=851796&r2=851797

Enterprise headers were added to trunk by r850566, long after the 4.1 branching by r829867.
Comment 5 Kishore 2008-08-29 18:39:58 UTC
I built kdepim again today and it does seem to be fixed. Thanks!