Bug 169801 - Web shortcuts are case sensitive but errors don't reflect that
Summary: Web shortcuts are case sensitive but errors don't reflect that
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 4.1.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 216596 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-08-25 17:59 UTC by Mark Williamson
Modified: 2010-02-01 12:17 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Williamson 2008-08-25 17:59:22 UTC
Version:           4.1.00 (KDE 4.1.0) (using 4.1.00 (KDE 4.1.0), 4.1.0-3.fc9 Fedora)
Compiler:          gcc
OS:                Linux (i686) release 2.6.25.14-108.fc9.i686

Web shortcuts are (currently) case sensitive but the error message displayed if the case is used wrongly (e.g. gG: instead of gg:) is "Protocol not supported: gg" with all lower case.

For KDE 3, this was reported here:
https://bugs.kde.org/show_bug.cgi?id=105734
https://bugs.kde.org/show_bug.cgi?id=106559

and apparently was fixed by making web shortcuts truly case insensitive instead of passing unknown strings to kio (as I understand it).

This bug seems to be have recurred on KDE 4.1 :-( so I chose to file it in a new Bugzilla entry to reflect it being a different occurrence.
Comment 1 Brendon Higgins 2009-09-05 11:01:03 UTC
Bug still exists in 4.3.1.
Comment 2 Frank Reininghaus 2009-11-29 21:54:04 UTC
*** Bug 216596 has been marked as a duplicate of this bug. ***
Comment 3 Nicolas L. 2009-12-17 10:37:46 UTC
can someone review this patch and tell me if i can commit ?

Index: kio/kio/kurifilter.cpp
===================================================================
--- kio/kio/kurifilter.cpp      (révision 1062473)
+++ kio/kio/kurifilter.cpp      (copie de travail)
@@ -90,7 +90,7 @@
 KUriFilterData::KUriFilterData( const QString& url )
     : d( new KUriFilterDataPrivate( KUrl(url), url ) )
 {
-    d->typedString = url;
+    d->typedString = url.toLower();
 }
Comment 4 Nicolas L. 2010-02-01 12:17:30 UTC
sorry i forgot to tell on my commit log but this is now fixed in kde 4.4 and in trunk:

4.4 commit : http://websvn.kde.org/?view=revision&revision=1083502
trunk  commit : http://websvn.kde.org/?view=revision&revision=1083503