Bug 169563 - [PATCH] fetch / check on selected key for KMail do not stop
Summary: [PATCH] fetch / check on selected key for KMail do not stop
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: encryption (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Will Stephenson
URL:
Keywords:
: 170286 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-08-22 02:24 UTC by dmoyne
Modified: 2009-01-23 20:59 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch (490 bytes, patch)
2008-12-09 17:15 UTC, Will Stephenson 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dmoyne 2008-08-22 02:24:45 UTC 
Version:           2.0.0 (using 4.1.00 (KDE 4.1.0), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-19-generic

This bug maybe linked to KMail : when selecting the key to use for either signature or encryption for Kmail in Kgpg then some fetch / check windows open that never close as if the job could not be completed ; strange for freshly created keys by same Kgpg
Comment 1 Steffen Schoenwiese 2008-08-23 15:26:23 UTC 
Same problem here with the i686 version
Comment 2 Rolf Eike Beer 2008-08-30 19:23:07 UTC 
Can you please describe in detail what you are doing? If you do this inside KMail it has nothing to do with KGpg.
Comment 3 Steffen Schoenwiese 2008-08-30 20:35:46 UTC 
This happened when I tried to assign an encryption/signing key to an identity in both KMail and Kontact. I didn't use KGpg explicity but I think the window title said KGpg (I may be mistaken, will try it again soon and report here)
Comment 4 dmoyne 2008-09-03 11:18:07 UTC 
It is done inside KMail
Comment 5 dmoyne 2008-12-08 01:39:15 UTC 
I confirm this bug :
when selecting a key as set in Kgpg once the window "Your signature key..." opens once a key is chosen 2 windows open :
- one window "Recovering key"
- another window "Verifying key"
bothe stay open with a cursor moving right an left for ever.
To get rid of these 2 extra windows I can select their "cancel" button without knowing whether this will somehow invalid or nor the choice of my key.
Regards
Comment 6 Will Stephenson 2008-12-09 17:10:39 UTC 
*** Bug 170286 has been marked as a duplicate of this bug. ***
Comment 7 Will Stephenson 2008-12-09 17:15:11 UTC 
Created attachment 29180 [details]
Patch

This should fix; (done() was never emitted), but I'd appreciate it if Marc could confirm it's in the right place.
Comment 8 Will Stephenson 2008-12-09 17:19:59 UTC 
Should fix https://www.intevation.de/roundup/kolab/issue3160 too.
Comment 9 Marc Mutz 2008-12-09 18:02:53 UTC 
Almost. This would only fix it for KeyListJob. The correct fix is to add it to slotFinished() in threadedjobmixin.h
Comment 10 Marc Mutz 2008-12-09 18:06:54 UTC 
SVN commit 894938 by mutz:

Fix missing emission of done() signal.
BUG:169563

 M  +2 -1      threadedjobmixin.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=894938
Comment 11 Steffen Schoenwiese 2008-12-09 18:10:19 UTC 
Thanks a lot, guys, this bug has been a real pain and caused me to switch to thunderbird again. Will try again when the next beta comes out :-)
Comment 12 Will Stephenson 2008-12-09 22:51:45 UTC 
I'll take care of committing it to trunk and 4.1 branch tomorrow, unless Marc has a sleepless night
Comment 13 Will Stephenson 2008-12-10 10:02:45 UTC 
SVN commit 895192 by wstephens:

Port r894938 to trunk: Fix persistent progress dialogs for GPG key
operations.
CCBUG:169563


 M  +2 -1      threadedjobmixin.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=895192
Comment 14 Will Stephenson 2008-12-10 10:10:56 UTC 
SVN commit 895194 by wstephens:

Backport r894938: Fix persistent progress dialogs for GPG key
operations.
CCBUG:169563


 M  +2 -1      threadedjobmixin.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=895194