Bug 168012 - Thumbnails not shown in find similar items tool so they can't be used for drag and drop
Summary: Thumbnails not shown in find similar items tool so they can't be used for dra...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Drag&Drop (show other bugs)
Version: 0.10.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-01 17:44 UTC by Gandalf Lechner
Modified: 2022-01-13 07:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gandalf Lechner 2008-08-01 17:44:23 UTC
Version:           0.10-beta3 (using 4.1.00 (KDE 4.1.0), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-17-generic

The find similar items tool is apparantly designed to work via drag and drop of a reference image. However, opening this tool in the left sidebar, the thumbnails are not shown any more, so there is nothing the user could drag and drop onto the tool.
Comment 1 Andi Clemens 2008-08-15 17:40:20 UTC
You can drag an image onto the fuzzy searches sidebar and wait a while... it will open the sidebar and you can drop the image in there.
But there is a much faster way: While displaying / selecting an image, open the image menu and choose "Find Similar..."

I will close this report if you don't mind.

Andi
Comment 2 Gandalf Lechner 2008-08-15 19:09:23 UTC
I agree that the search tool itself does work, and there are no problems using it via the menu. However, opening the side bar and looking at the tool, many users will think it's broken because there is no way to select a reference picture. In particular, the "drag and drop" info is misleading in this situation.
Comment 3 Andi Clemens 2008-08-15 19:39:59 UTC
Ok I agree on that. We should just change the message I guess, it is the 
easiest way.

Gilles,

what do you think?
Comment 4 Andi Clemens 2008-08-15 19:48:37 UTC
To be more precise, there are two solutions right now I can think of:

1. change the message
2. display the current selected album (and, if selected, the included subtree) in the icon view when selecting "find similar", but only if the tool has been reset, otherwise show those images that match the chosen image.

Point 2 will maybe be easier to implement when we are using a new model-view-concept after the 0.10 release...
Comment 5 Gandalf Lechner 2008-08-15 19:58:51 UTC
Solution 2 would be better in my opinion, since it would also allow to use the nice drag and drop feature. 
Comment 6 caulier.gilles 2008-08-18 08:25:57 UTC
If you continue the discution here, so the filme must be re-open

Gilles
Comment 7 Andi Clemens 2008-10-19 02:11:03 UTC
Just thought about this and implemented a way to have the current viewed album displayed in the similar tool, if no search has been done before. But somehow this is weird and doesn't make sense.
If you want to change an album, you first need to reset the tool.
Then you need to go to albums tab (or tags / date / search) and select the album. Now you go back to the similar tool and drag the image into the similar widget. This is a strange work-flow.
So I really think it should be the way it is, we only should change the message there and maybe add the action to the context menu as well, so that when viewing in image you can change quickly to the similar tool.

What do you think?
My second proposal from comment #4 is not that usable once I had it implemented.

Andi
Comment 8 caulier.gilles 2008-12-03 13:08:22 UTC
Andi,

Your proposal about to add contextual menu entry to select new item for similar search is fine for me.

Gilles
Comment 9 Andi Clemens 2008-12-03 13:52:21 UTC
Should the context menu entry also be visible in preview mode (displaying current image)?

Andi
Comment 10 caulier.gilles 2008-12-03 15:55:52 UTC
Yes, i think so, to have an homogenous interface

Gilles
Comment 11 Andi Clemens 2008-12-03 16:43:39 UTC
SVN commit 892129 by aclemens:

add "Find Similar" action to AlbumIconView and PreviewView

CCBUG:168012

 M  +10 -4     albumiconview.cpp  
 M  +6 -5      albumiconview.h  
 M  +3 -0      albumwidgetstack.cpp  
 M  +2 -1      albumwidgetstack.h  
 M  +6 -0      digikamview.cpp  
 M  +14 -9     imagepreviewview.cpp  
 M  +1 -0      imagepreviewview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=892129
Comment 12 Andi Clemens 2008-12-03 16:44:46 UTC
We should also change the label in the ImageWidget (the text about Drag & Drop).

Any suggestions?

Andi
Comment 13 caulier.gilles 2008-12-03 19:15:06 UTC
Andi

The current message about D&D still fine. You just need to add another phrase to describe the contextual menu workflow.

Gilles

Comment 14 Andi Clemens 2008-12-03 20:58:19 UTC
SVN commit 892214 by aclemens:

first attempt of a more meaningful description for find similar widget

CCBUG:168012

 M  +2 -1      fuzzysearchview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=892214
Comment 15 Andi Clemens 2008-12-05 00:17:21 UTC
Gilles, Marcel, Arnd,

since the label is changed now and the action was added to the context menu of the album iconview and the previewwidget, should we close this one?
I really don't think that it is very usuable when you display the current selected album in this tool. The way it is now seems to be the best solution.

Andi
Comment 16 caulier.gilles 2008-12-05 06:10:07 UTC
yes, it's fine for me

Gilles
Comment 17 Andi Clemens 2008-12-08 11:41:24 UTC
Ok, closing this one now...