Bug 167538 - Cannot add objects to Kross::ActionCollection
Summary: Cannot add objects to Kross::ActionCollection
Status: ASSIGNED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Sebastian Sauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-27 18:50 UTC by Ben Boeckel
Modified: 2008-12-28 00:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Boeckel 2008-07-27 18:50:47 UTC
Version:            (using KDE 4.0.98)
Installed from:    Compiled From Sources

I would like to be able to add QObjects to the action collection as well. I can add them at the trunk (Manager) and the leaf (Action), but anything that could be consolidated at the branch level has to be added to the leaves individually. Is there a way that it could be added to ActionCollection?
Comment 1 Sebastian Sauer 2008-07-29 04:48:12 UTC
proposal from MathStuf;

/KDE/kdelibs/includes/Kross/z

is:

#include "../../kross/x/y"


core/
    actioncollection.h
        Kross/ActionCollection
    action.h
        Kross/Action
    childreninterface.h
        Kross/ChildrenInterface
    errorinterface.h
        Kross/ErrorInterface
    interpreter.h
        Kross/Interpreter
        Kross/InterpreterInfo
    manager.h
        Kross/Manager
    metafunction.h
        Kross/MetaFunction
        Kross/MetaFunction/Option // use the '/' ?
    metatype.h
        Kross/MetaType
        // Other MetaType* classes?
    object.h
        Kross/Object
    script.h
        Kross/Script
    wrapperinterface.h
        Kross/WrapperInterface

ui/
    model.h
        Kross/ActionCollectionModel
        Kross/ActionCollectionProxyModel
    plugin.h
        Kross/ScriptingPlugin
    view.h
        Kross/ActionCollectionEditor
        Kross/ActionCollectionView
Comment 2 Ben Boeckel 2008-12-28 00:35:31 UTC
If I were to make patches for this, would it be possible for this to make it into 4.2 (or even 4.3)? From what I can see, Kross::ActionCollection would need to grow an inheritance from Kross::ChildrenInterface. The Kross plugins would also need to add objects from parents of the action when being executed. Since this breaks binary compatibility and, AFAIK, KDevelop and KOffice2 are the only (or at least biggest) users of Kross and they do not yet have major releases where binary incompatibility would cause too much fallout.