Bug 167184 - Composer and Disc Number tags are not updated in the file
Summary: Composer and Disc Number tags are not updated in the file
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Local (show other bugs)
Version: 2.0-alpha
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords: release_blocker
: 166908 167200 167858 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-07-22 05:53 UTC by Romário Rios
Modified: 2009-12-09 11:28 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Romário Rios 2008-07-22 05:53:01 UTC 
Version:           1.83 (using 4.00.98 (KDE 4.0.98 (4.1 RC1)), Kubuntu packages)
Compiler:          gcc
OS:                Linux (i686) release 2.6.24-19-generic

"Edit track details" dialog opens normally, but the changes are not applied.
Comment 1 Lydia Pintscher 2008-07-22 12:22:46 UTC 
Should be fixed in alpha 2 which will be released in a few hours.
Please reopen if it is still happening with alpha 2 once you can update to it.
Comment 2 Seb Ruiz 2008-07-22 12:38:05 UTC 
*** Bug 167200 has been marked as a duplicate of this bug. ***
Comment 3 Romário Rios 2008-07-26 00:02:03 UTC 
This bug was not totally fixed. Sometimes the tag editor works, sometimes it does not.
Comment 4 Romário Rios 2008-07-26 00:03:27 UTC 
This bug was not totally fixed. Sometimes the tag editor works, sometimes it does not.

(Resending comment 'cause I forgot reopening it).
Comment 5 Mark Kretschmann 2008-07-31 17:17:59 UTC 
*** Bug 167858 has been marked as a duplicate of this bug. ***
Comment 6 Mark Kretschmann 2008-08-07 10:03:31 UTC 
Is this still valid? Nota bene, I've noticed that Amarok currently requires a restart to pick up collection changes after a rescan.

Could this be the case here too?
Comment 7 Matthew Harker 2008-08-20 13:34:55 UTC 
I can confirm this. In amarok2 the metadata for the file "1 Lion.flac" reads:

Title: Lion
Artist: Macross Frontier
Album: Lion

However using metaflac --list on the file yields the following:

  comments: 8
    comment[0]: ALBUM=Lion - Macross Frontier OP2 Sinble
    comment[1]: ARTIST=May'n (Sheryl Nome) / Nakajima Megumi (Ranka Lee)
    comment[3]: DATE=2008
    comment[4]: GENRE=Anime
    comment[5]: TITLE=Lion
    comment[6]: TOTALTRACKS=4
    comment[7]: TRACKNUMBER=1
Comment 8 Maarten Wisse 2008-08-20 19:16:49 UTC 
Isn't this just another description of the problem reported in bug 166908?
Comment 9 Lydia Pintscher 2008-08-20 19:43:11 UTC 
*** Bug 166908 has been marked as a duplicate of this bug. ***
Comment 10 Lydia Pintscher 2008-08-20 19:43:59 UTC 
Thanks Maarten. I knew there was a similar bug...
Comment 11 Alex Merry 2008-09-07 15:41:30 UTC 
Partially fixed in r858155.

We don't update Composer or Disc Number yet.
Comment 12 Alex Merry 2008-09-07 17:47:52 UTC 
Fixed the rest of the way in r858232: OGG Vorbis and FLAC files now save composer and discnumber tags.

MP3 should, in theory, save the composer tag.  However, there seems to be a bug in TagLib that means the ID3v2 tag doesn't get written, so we can't save that data.  Once TagLib is fixed, it should work, though.
Comment 13 Alex Merry 2008-09-07 18:16:22 UTC 
Actually, it does work with MP3.  It turns out the id3v2 command line utility can't cope with the way TagLib writes ID3v2 tags.  I'm not sure who's at fault there, though.  I suspect the i3v2 utility.
Comment 14 Alex Merry 2008-09-07 18:29:09 UTC 
Yes, after some testing, it seems the the id3v2 utility just silently ignores ID3v2.4 tags.  So it's all good.