Bug 167085 - Color selection in sketch search tool looks plain black [KHueSaturationSelector relevant]
Summary: Color selection in sketch search tool looks plain black [KHueSaturationSelect...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Similarity (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-20 19:16 UTC by Gandalf Lechner
Modified: 2019-08-18 15:46 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.10.0
Sentry Crash Report:


Attachments
screenshot (16.90 KB, image/jpeg)
2008-07-20 19:17 UTC, Gandalf Lechner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gandalf Lechner 2008-07-20 19:16:25 UTC
Version:           0.10.0-beta2 (rev.: 835081) (using 4.00.98 (KDE 4.0.98 (4.1 RC1)), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-17-generic

In the new fuzzy search tool based on a sketch, the color selection box where one can pick the color of the brush looks plain black. Color selection still works, however (see screenshot below).
Comment 1 Gandalf Lechner 2008-07-20 19:17:40 UTC
Created attachment 26287 [details]
screenshot
Comment 2 Andi Clemens 2008-07-20 19:19:47 UTC
I think it is KDE4libs fault, I once had a nice colorful selection tool, but now it is just black, too. I'm not quite sure (never looked at that code before) but I guess this is a standard KDE widget...
Comment 3 caulier.gilles 2008-07-20 22:01:10 UTC
Andi,

Here with KDE 4.0.3, all work fine. I have tested few week ago with KDE 4.1 beta1 and i can reproduce the problem. Sound like a regression from KDELibs. Code relevant is here :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/fuzzysearch/fuzzysearchview.cpp#281

Also, look error messages from the console: there is and HSV color space conversion problem. Classes relevant are KHueSaturationSelector and KColorValueSelector. 

If the problem come from really KDELibs, I propose to re-assign this bug to KDElibs. But I cannot check this problem now (not KDE 4.1 here). 

Gilles Caulier
Comment 4 Gandalf Lechner 2008-07-20 22:35:06 UTC
It really seems to be a kde problem: When I run digikam 0.10 from a kde3 session, the colour selection tool looks colourful as it should. But from a kde4 (4.1 rc1) session, the box is black.
Comment 5 Andi Clemens 2008-07-20 22:39:30 UTC
Yes, you are right... I knew that I had seen the color dialog before, and now 
I know when this was  :-)
When starting from a KDE3 session, I can see the widget completely, starting 
in a KDE4 session or at least with the KDE4 env variables set, I can't see it 
anymore (via xhost or ssh forwarding).
Comment 6 caulier.gilles 2008-07-28 14:39:27 UTC
I re-assign to KDELibs, since with KDE4.0.x, this problem do not appears. 
It's relevant of KHueSaturationSelector widget. 
This problem can be reproduced with KDE 4.1.x.

Gilles Caulier

Comment 7 Andi Clemens 2008-08-15 18:03:52 UTC
I just noticed that the color selection widget works in the HSV imageplugin of digiKam, but not in the sketch tool. I will need to take further investigations on that.

Andi
Comment 8 Andi Clemens 2008-08-15 18:10:36 UTC
Oh I see those are not the same widgets... sorry for this unnecessary post... 
Comment 9 Andi Clemens 2008-08-15 18:30:41 UTC
I'll reassign this one to digiKam since it seems to be the problem with our implementation.

Andi
Comment 10 caulier.gilles 2008-08-15 18:52:48 UTC
Andi,

I have tested with a last revision of KDE4 from trunk and Qt4.1 provided by Mandriva cooker, and sound like the bug have been fixed. On Sketch tool, the widget run properlly now.

Gilles
Comment 11 Andi Clemens 2008-08-15 19:03:03 UTC
I'll test that... I played around with the colorChooserModes and I got back my 
colors. But before touching digiKam code I'll update KDElibs first.

Andi
Comment 12 Gandalf Lechner 2008-08-15 19:05:23 UTC
The widget works also as it should with the latest kde packages in kubuntu
Comment 13 Gandalf Lechner 2008-08-15 19:12:45 UTC
Sorry, that conclusion was too fast - right now the bug seems to be back :-( 
Either that's due to the digikam checkout I just did, or it is sometimes working, and sometimes not.
Comment 14 Andi Clemens 2008-08-15 19:38:56 UTC
Nothing has changed in digiKam code so far... I also can still confirm it...
Comment 15 caulier.gilles 2008-08-18 22:29:03 UTC
*** Bug 169404 has been marked as a duplicate of this bug. ***
Comment 16 Andi Clemens 2008-08-21 11:56:59 UTC
Ahh damn again I have to post the webSVN link by myself, PLEASE repair the commit keywords!!!

SVN commit 850342 by aclemens:

colors were not set properly in the fuzzy search widget. This commit fixes the issue.

-> new member QColor selColor to hold the currently selected color
-> new method setColor() to set the colors in the widgets
-> modified slotHSChanged() and slotVChanged()

http://websvn.kde.org/?view=rev&revision=829870