Bug 166970 - Classic menu style separators can't be customized by translators
Summary: Classic menu style separators can't be customized by translators
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-kickoff (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-19 04:37 UTC by Daniel Calviño Sánchez
Modified: 2013-02-18 10:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Calviño Sánchez 2008-07-19 04:37:29 UTC
Version:            (using Devel)
Installed from:    Compiled sources

In KDE 3, a bug (Bug 135465) to use separators between Name and Description in "Name Description" format was opened after the separators were removed in KDE 3.5.5. Eventually, Name and Description were separated by a '-', and also translators were given the option to use different separators if they fit better with their language (as can be seen in commit http://websvn.kde.org/?view=rev&revision=635743).

However, in KDE 4 the separators are gone again, and now there isn't even the option for translators to set them.

I have just looked through the code in SVN and saw that the changes (at least for the classic menu, I don't know about Kickoff) would be just changing in kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp (revision 828782):

d->addItem(d->formatComboBox, i18nc("@item:inlistbox Format:", "Name Description"), MenuLauncherApplet::NameDescription);

to add the default separator (if some default separator is set, of course) and to add context information for translators so they know that they can set the separator as desired, and in kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.cpp (revision 826888):

action->setText(QString("%1 %2").arg(name).arg(text));

in a similar way to the changes made in commit 635743 (http://websvn.kde.org/branches/KDE/3.5/kdebase/kicker/kicker/ui/service_mnu.cpp?r1=578930&r2=635743&pathrev=635743)

Sorry for not providing a real patch, but at this moment I don't have a KDE 4 development environment.