Bug 166943 - System displays "Image loading... close window" but nothing happens. Works correctly in Firefox
Summary: System displays "Image loading... close window" but nothing happens. Works co...
Status: RESOLVED NOT A BUG
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 4.7.2
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-18 17:56 UTC by Frans Leerink
Modified: 2012-10-19 23:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frans Leerink 2008-07-18 17:56:20 UTC
Version:           3.5.7 (using 3.5.7 "release 72.9" , openSUSE 10.3)
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.22.17-0.1-default

Hello,

I view the following URL with Konqueror: 

            http://www.seafarer.gr/boat75-BAVARIA_33_Cruiser

and want to view from the displayed URL the photo #1  |  photo #2  |  photo #3. If I click on one of the photos the system ask me: 

"This site is requesting to open
http://www.seafarer.gr/showbig.php?obr=http://ww...33sal3_hi.jpg&popisek=BAVARIA%2033%20Cruiser
in a new browser window via JavaScript.
Do you want to allow this?"

As I click on "Allow" the System displays:
            "Image loading... 
 
             close window" 

but nothing happens. The same action works correctly in Firefox.

Regards,    Frans
Comment 1 Maksim Orlovich 2008-07-18 18:23:58 UTC
Seems like we want getListener to return jsUndefined() and not jsNull() when the listener is not set.
Comment 2 Maksim Orlovich 2008-07-18 18:40:09 UTC
... The other path (for IE?) seems to use onresize on an image element. We definitely don't want to do that. 

So I'll likely commit the below once 4.1 is out of the door (to get it some testing time):

Index: ecma/kjs_dom.cpp
===================================================================
--- ecma/kjs_dom.cpp	(revision 831910)
+++ ecma/kjs_dom.cpp	(working copy)
@@ -566,7 +566,7 @@
   if ( jsListener && jsListener->listenerObj() )
     return jsListener->listenerObj();
   else
-    return jsNull();
+    return jsUndefined();
 }
 
 void DOMNode::pushEventHandlerScope(ExecState *, ScopeChain &) const

Comment 3 Ariya Hidayat 2008-07-21 19:27:26 UTC
Seems this change will break IE compatibility. According to my check, IE returns null while Firefox and Opera give undefined.

W3C DOM specification seems to not say anything. Or am I missing something?
Comment 4 Maksim Orlovich 2008-07-21 21:06:46 UTC
Only that Opera behavior is more complex, and you haven't yet learned that DOM2 HTML is basically just a list of methods and is really basically useless.

http://www.whatwg.org/specs/web-apps/current-work/#event4 OTOH suggests 'null', but it may be changed. I'll send a note when I get home, I guess.

Comment 5 FiNeX 2010-08-23 22:11:57 UTC
@Maksim: what about this old report? The bug is still valid.
Comment 6 Dawit Alemayehu 2011-12-31 00:58:50 UTC
I see the same blank window in all the browsers I tested this with: Konqueror w/ (webkit/khtml), Firefox, Chromium. So I do not see the problem at this point. The only difference I see is that in Konqueror + khtml, I simply so not see the  "image loading..." and close window links no matter how much I resize the window.
Comment 7 Frans Leerink 2011-12-31 21:26:11 UTC
Hello, 

I have retested this problem with openSUSE 12.1 KDE 4.7.2 and Konqueror 4.7.2 and the problem is still the same.

However Firefox 8.0 in openSUSE 11.4 / KDE 4.6.0 displayed the pictures correctly while Firefox 9.0 in openSUSE 12.1 / KDE 4.7.2 has the same problem as reported in this problem note.

Regards,   Frans
Comment 8 Dawit Alemayehu 2012-10-19 23:10:49 UTC
All the current versions of Chromium and Firefox show the same thing as well ; so this is a site issue.