Version: 0.10.0-beta2 (rev.: 831948) (using 4.00.83 (KDE 4.0.83 (KDE 4.1 Beta2), Kubuntu packages) Compiler: gcc OS: Linux (x86_64) release 2.6.24-17-generic In the image editor, switching to fullscreen turns of the thumbnail bar. But when switching off the fullscreen mode, the thumbnail bar does not reappear.
I can confirm this, you have to toggle the "View->Show Thumbnails" option twice to get it back.
Another note: The Shortcut CTRL+T doesn't work, too.
This also can be confirmed for showFoto. In showFoto the code in http://lxr.kde.org/source/extragear/graphics/digikam/showfoto/showfoto.cpp#627 should do the trick, but it doesn't. Entering this code in digiKam also doesn't bring back the thumbbar.
I have added this to imageeditor: Index: utilities/imageeditor/editor/editorwindow.cpp =================================================================== --- utilities/imageeditor/editor/editorwindow.cpp (revision 832135) +++ utilities/imageeditor/editor/editorwindow.cpp (working copy) @@ -1010,6 +1010,7 @@ menuBar()->show(); statusBar()->show(); + slotToggleShowBar(); showToolBars(); if (d->removeFullScreenButton) @@ -1036,6 +1037,7 @@ // hide the menubar and the statusbar menuBar()->hide(); statusBar()->hide(); + thumbBar()->hide(); if (d->fullScreenHideToolBar) { But somehow it doesn't work. Right now I'm sitting here with gdb to find out what is happening. The problem is now that the thumbbar is always restored, even if the "View Thumbnails" action is turned off. When running gdb and watching the execution of digiKam line by line, I can see that thumbBar()->hide() is called like it should be, but somehow the thumbbar is visible in the end. I have no idea why... but this little patch fixes at least the general problem.
I found the problem. In http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp#1003 the virtual method toggleGUI2FullScreen() is called, which has been overwritten in ImageEditor class (without implementation), but somehow it is called anyway. http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp#819 So disabling the method call works... showFoto also re-implements the code in toggleGUI2FullScreen(), but never calls it. And it seems to re-implement the same code defined before in the ImageWindow class. So I think this is wrong. Question is should this method be removed from both showFoto and EditorWindow and if not, why is showFoto implementing the same code? And is the code in ImageWindow class really right? Why enable thumbBar if it is disabled in the ToggleAction? Andi
Created attachment 26105 [details] patch #1
A note: CTRL+T seems to be a taken by the action "Insert text...", so this is why it doesn't work.
Andi, I have separate the way to re-implement the virtual method toggleGUI2FullScreen() in the pass because thumbbar have been used only in showfoto... (KDE3 code only). Now, thumbbar is used in image editor too. code can be factorized as well in editorwindow.cpp. The reason about this dysfunction is that i haven't yet tested all cases of course. it's a side effect (:=))) Gilles
This error is also related to showFoto from KDE3 branch: 1. Open a folder 2. Hide the thumbbar 3. Goto fullscreen 4. Exit fullscreen The thumbbar will be displayed. So I really guess // If Hide Thumbbar option is checked, restore it. if (!m_showBarAction->isChecked()) d->thumbBar->show(); is wrong... or isn't it?
A simple Index: showfoto/showfoto.cpp =================================================================== --- showfoto/showfoto.cpp (revision 831859) +++ showfoto/showfoto.cpp (working copy) @@ -628,7 +628,7 @@ d->rightSidebar->restore(); // If Hide Thumbbar option is checked, restore it. - if (!d->showBarAction->isChecked()) + if (d->showBarAction->isChecked()) d->thumbBar->show(); } else would do the trick... should I commit this?
The above patch can also be applied to KDE4 version, which makes patch #1 obsolete... still working fine.
Andi, Patch from comments #10 sounds logic (:=))). i cannot test here. If it fine for you, it's right for me. Anybody else can valid this simple fix ? Gilles Caulier
SVN commit 833245 by aclemens: When leaving fullscreen mode, the thumbbar was gone. This happenend because the state of the thumbbar was always toggled. CCBUGS:166472 M +1 -1 showfoto.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=833245
SVN commit 833246 by aclemens: backport commit #833245 from KDE3 branch CCBUGS:166472 M +1 -1 showfoto.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=833246
So this one is fixed for now, but what about the default shortcut? It collides with the "Insert Text" imageplugin.
As of revision 833596, the thumbbar is still not working properly on my system. Something seems to be wrong in the code, since all of the following types of behaviour occur (I assigned a different shortcut to the toggle thumbbar action, so that's not the problem): 1 - Switching back from fullscreen doesn't reactivate the thumbbar 2 - When switching to fullscreen, the thumbbar stays visible 3 - Pressing the toggle thumbbar button doesn't toggle the thumbbar (you sometimes have to press it twice) Sometimes, however, the behaviour is just as expected, i.e. going to fullscreen hides the thumbnails and going back reactivates it; this seems to depend on the number of times you pressed the toggle thumbbar button. Gandalf
Weird, can't reproduce any of the problems ... (The only thing which is a bit annoying is the slow change to full-screen and back: there seem to be several repaints of the image at different sizes and this is obervable even on a pretty fast machine.....)
This is strange, it is working all the time here. Have you really compiled the newest SVN or the final 0.9.4 release and actually installed it on your system? Andi On Thursday 17 July 2008 09:21:19 you wrote: [bugs.kde.org quoted mail]
Of course this is true for the 0.10 series also. I just toggled both versions to fullscreen and back like a maniac (holding SHIFT+CTRL+F all the time or pressing the button). After 30 tries I gave up, I just can not reproduce this anymore.
Again please make sure to actually INSTALL the apps in your system, otherwise it might get linked against the system wide libs on startup and NOT against the new ones in your build dir.
Well, I don't want to exclude the possibility that I did an error in the compile/install procedure, also in view of the other bugs nobody else seems to experience ;-) So here's what I did: svn up digikam, svn up kipi-plugins, svn up cmake, all at revision 833633. Then I removed everything in my build directory, ran cmake ..., make and sudo make install to install the stuff. Afterwards, in digikam under help->about digikam it reads "Version 0.10.0-beta2 (rev.: 833633)", so I had the impression it installed correctly. Is there some other way I can check the success of the installation?
> svn up digikam, svn up kipi-plugins, svn up cmake, all at revision 833633. > Then I removed everything in my build directory, ran cmake ..., make and > sudo make install to install the stuff. Afterwards, in digikam under > help->about digikam it reads "Version 0.10.0-beta2 (rev.: 833633)", so I > had the impression it installed correctly. Is there some other way I can > check the success of the installation? The one thing that could happen is that you might have installed two versions of digiKam 0.10... in different paths on your system (but this is just a guess). You can try to use "updatedb" and after that "locate -i digikam | grep bin | grep -v <your digikam build dir (home?)>" If you can find more than one binary, maybe the old one is loaded instead of the new one... this happened to me once where I forgot to set the prefix for cmake, it just installed it in /usr instead of /opt/kde4 Andi
locate returns /usr/bin/digikam /usr/bin/digikamthemedesigner /usr/lib/kde4/bin/digikam /usr/lib/kde4/bin/digikam-camera /usr/lib/kde4/bin/digikamthemedesigner /usr/local/bin/Digikam-Update The entries in /usr/bin belong to kde3, and the others to kde4. The last item is just a script for checkouts, so I think everything is fine.
Why is your KDE4 installed in /usr/lib...? But anyway you seem to have only one copy of digiKam 0.10 running... hmmm. How do you start digiKam? With a special KDE4 user? What are your env settings? Andi On Thursday 17 July 2008 12:15:40 you wrote: [bugs.kde.org quoted mail]
As far as I know, /usr/lib/kde4 is the default path for the kde4 installation under kubuntu. I start digikam directly from the konsole or with krunner, no special kde4 user involved. The env settings I used are DIGIKAMKDE4=/usr/lib/kde4 export PATH=/usr/lib/kde4/bin/:$PATH export LANG=C export KDEDIRS=$DIGIKAMKDE4:/usr/lib/kde4/ export LD_LIBRARY_PATH=$DIGIKAMKDE4/lib:$LD_LIBRARY_PATH export LDPATH=$DIGIKAMKDE4/lib:$LDPATH export PATH=$DIGIKAMKDE4/bin:$PATH export PKG_CONFIG_PATH=$DIGIKAMKDE4/lib/pkgconfig export MARBLE_PATH=$HOME/NBB/SOFTWARE/Marble/ export LD_LIBRARY_PATH=$MARBLE_PATH/lib:$LD_LIBRARY_PATH export LDPATH=$MARBLE_PATH/lib:$LDPATH export PATH=$MARBLE_PATH/bin:$PATH export PKG_CONFIG_PATH=$MARBLE_PATH/lib/pkgconfig:$DIGIKAMKDE4/lib/pkgconfig export INCLUDE_DIR=$MARBLE_PATH/include:$INCLUDE_DIR export CMAKE_INCLUDE_PATH=$MARBLE_PATH/include:$DIGIKAMKDE4/include export CMAKE_LIBRARY_PATH=$MARBLE_PATH/lib:$DIGIKAMKDE4/lib The marble related paths I just copied from Arnd's settings, they are not relevant here. Earlier I tried a custom install path for digikam, but this always gave errors in cmake or make, so I was happy that it worked with /usr/lib/kde4. Is there anything wrong with this setup? At least it compiles and installs ...
It seems to be ok... but it is strange that only you still encounter those thumbbar problems... because now it is fixed. It looks that you are running an old version somehow, but I don't know why... Andi
Andi, Unforget that the code fixed is compiled in the shared libdigikam.so. This depand if the shared lib is really updated at the right place when digikam bin program is executed... Gilles 17 Jul 2008 12:25:18 -0000, Andi Clemens <andi.clemens@gmx.net>: [bugs.kde.org quoted mail]
Gandalf, What news about this entry ? Gilles
After revision 838670 which I checked out some minutes ago, the situation still looks the same here, as described in comment #16. Maybe something is still wrong with my setup? How could I check this? Gandalf
You really need to make sure if the newest libs are used, so first thing to do here is actually install digiKam on your system. Make sure LD_LIBRARY_PATH is set correctly and if it is not set at all, initialize it with your KDE4 install path (for example export LD_LIBRARY_PATH="/opt/kde4/lib:$LD_LIBRARY_PATH". I really think you are using an old lib all the time. If you have the possibility, create a new user and let him start a real KDE4 desktop session. All variables should be set correct then. Try to start digiKam as this new KDE4 user.
Well, I also believe that something might be wrong on my side - I just can't figure out what it is ... So I created a new user, started a kde4 session, started digikam from there, but it is the same situation as with my default user. As far as variables like LD_LIBRARY_PATH are concerned, my settings are in comment #25 and hopefully correct. Moreover, I am pretty sure that I do install the compiled version, since I see changes after fresh checkouts - for example the recent fix of this bug: http://bugs.kde.org/show_bug.cgi?id=167124 . One strange thing puzzled me, tough: Although after the checkout it says "updated to revision 838992", after the installation digikam --version says "rev. 830788". Is that information not updated regularly or is this an indication of an error in the installation? Gandalf
This is SVN. The revision number will increase all the time someone commits a change (for the whole KDE repository, not only digiKam). digiKam is "just" a folder inside this repository. If someone makes changes to lets say amarok, revision number will increase. But since digiKam was not changed, its state is still set to an older revision. So nothing is wrong with your installation. But again it is not said that you install it correctly, I have setup my development environment the way that I can just compile in my source folder in the Eclipse workspace and immediately see changes, although it is not installed system-wide. This speeds up the development process a lot, because you don't have to do "make && su -c "make install"" all the time. This works as long as I change libs (or in general code) that is not loaded by kdeinit or other parts. But working on kioslaves for example always requires me to actually install digiKam system-wide. So if I made a change, I need to install it, test it, make another change, install again etc. That digiKam is starting is no indicator of a correct setup. Some libs might be pulled from /usr/lib/kde4, some from the folder the source code lives in. This can be controlled by the LD_LIBRARY_PATH variable, it tells the system were to look for libraries. What is found first will be used. So if somehow a wrong / old lib is found first (in your case by the kioslave), it will use this one and not the updated one you might have pulled and compiled from SVN. Please again gives us your env variables as the new user from the real KDE4 session. Do not login just by "su - kde4user", you have to do it from KDM and paste the env stuff. Also make sure if the kioslaves and all libdigikam*.so files in your KDE4 root path have the newest date. So if you installed yesterday, they should have that date and not an old one. If they have not, the libs are copied somewhere else. Try to locate all needed files with "locate -i libdigikam" or something like that. Andi
OK, here is what I find with my new user in a kde4 session. echo $LD_LIBRARY_PATH gives /usr/lib/kde4/lib, echo $KDEDIRS gives /usr/lib/kde4, these are also the settings I use in my checkout/compile/install script (which by the way does end with make and sudo make install). Any other variables I should look up? For the libdigikam*.so files and kioslaves: I found libdigikam files in my svn directory and in /usr/lib/kde4/lib, and nowhere else. The files libdigikam.so.1.0.0 and libdigikamdatabase.so.1.0.0 have today as their date, the others (like libdigikam.so, libdigikam.so.1) are about two week old symbolic links pointing to these two. Doing "locate -i kio_digikam" gave me loads of files in my svn directory and four files (kio_digikam albums, dates, search, tags) in /usr/lib/kde4/lib/kde4 - strange path, but seems to be correct since it also contains the other kio_slaves. These kio_digikam files are also from today. So I can't see any old versions that could be used by digikam instead of the fresh stuff, no idea how to proceed from here ... Gandalf
> Doing "locate -i kio_digikam" gave me loads of files in my svn directory > and four files (kio_digikam albums, dates, search, tags) in > /usr/lib/kde4/lib/kde4 - strange path, but seems to be correct since it > also contains the other kio_slaves. The path is not strange at all, but strangely you install KDE4 in /usr/lib/kde4... never seen that before. But this seems to be a kubuntu thinggy since Dotan also installs it there (I assume you use kubuntu, I guess you mentioned it somewhere before). All kioslaves on my system can be found in /opt/kde4/lib/kde4 and for KDE3 it is /opt/kde/lib/kde3, so this is normal. I can see no significant errors in your setup. Can you post the var KDEDIR, maybe this is pointing to your kde3 installation, although I don't believe it. Have you tried to remove the digikamrc and showfotorc from your kde home folder? I really don't have another clue anymore what is going wrong here. Maybe try to remove all digikam-0.10 files from your KDE4 root folder and install everything again. At least try to remove these libs and kioslaves: [..]/lib/kde4/kio_digikamalbums.so [..]/lib/kde4/kio_digikamdates.so [..]/lib/kde4/kio_digikamsearch.so [..]/lib/kde4/kio_digikamtags.so [..]/lib/kde4/libdigikam* Andi
Another idea: Try to start digiKam as the kde4 user in the real kde4 desktop. While running, open up a console and type lsof | grep -i digikam This will show all files opened by digiKam or the kioslaves. Maybe you will see a library path used there that is not normal...
Created attachment 26476 [details] output of lsof | grep -i digikam
Yes, installation in /usr/lib/kde4 is default in kubuntu. Did you really mean KDEDIR? That variable is empty here, but KDEDIRS is /usr/lib/kde4. I removed the libs you suggested, removed digikamrc and showfotorc, and installed the svn version again - the thumbnail bar is still gone when I switch back from fullscreen. lsof | grep -i digikam returns 316 lines, loads of imageplugins from .../lib/kde4, but also other stuff like /usr/lib/xine/plugins/... or /usr/lib/libraw1394.so.8.2.0. I've attached this output above, since I don't understand most of it, but it is maybe helpful for others. Gandalf
Gandalf, Please check this point : which digikamrc file is used to store all digiKam settings ? Typically with KDE3, your ~/.kde/share/config/... file is used with KDE4, it's your ~/.kde4/share/config/... If you still use ~/.kde/share/config/... file with KDE4, you will see any garbage in GUI (you mix settings from KDE3 and KDE4) Best Gilles Caulier
It looks as if the digikamrc within ~/.kde4/share/config is used. On the laptop I am trying this, there is no kde3-digikam any more, and I also removed its digikamrc. Then I changed some settings in kde4-digikam, and ~/.kde4/share/config/digikamrc was changed. Gandalf
If you set up a dedicated kde4 user, it will use the kde4 settings by default (if he didn't log into a KDE3 session before). Yes I mean KDEDIR, this is the var describing the current KDE install path. KDEDIRS should work, too. Your lsof output looks alright to me. Very strange... I don't know what is going wrong on your system.
AAAAAAAAAAAAAAAAAAAAAAAAAHHHHHH!!!!!! I always checked showFoto only to test this issue because it starts faster... and somehow it worked before in digiKam as well. But now I looked at the code again. We have only corrected this bug for showFoto, not digiKam!!! Gandalf sorry for this odyssey through your system settings! :-) I will fix it right now! Andi
SVN commit 839225 by aclemens: When leaving fullscreen mode, the thumbbar was not restored altough "Show Thumbbar" is checked. CCBUGS:166472 M +32 -32 showfoto/showfoto.cpp M +30 -30 utilities/imageeditor/editor/imagewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=839225
SVN commit 839236 by aclemens: backport commit #839225 from KDE4 branch CCBUGS:166472 M +39 -39 showfoto.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=839236
It should be fixed (really :-)) now. Gilles, since code is the same in ShowFoto and ImageWindow we might even move the content of toggleGUI2FullScreen to EditorWindow class (and make it virtual?).
Andi, > since code is the same in ShowFoto and ImageWindow we might even move the content of toggleGUI2FullScreen to EditorWindow class (and make it virtual?). The code is the same in showfoto and imagewindow. move the method to editorwindow which is the parent class for both. no need to make it as virtual. a virtual method is used to re-implement it to children classes. This not the case now. In fact you will factorize, that all... Gilles
Created attachment 26483 [details] move toggleGUI2FullScreen() to EditorWindow This patch will move toggleGUI2FullScreen() to EditorWindow and implement 2 virtual functions thumbBar() and rightSidebar() which return the appropriate widget for the toggleGUI2FullScreen method.
Andy, Patch is fine for me... Gilles
SVN commit 839320 by aclemens: Move toggleGUI2FullScreen() from ShowFoto and ImageWindow to EditorWindow and implement 2 virtual functions thumbBar() and rightSidebar() which return the appropriate widget for the toggleGUI2FullScreen method. CCBUGS:166472 M +46 -64 showfoto/showfoto.cpp M +8 -9 showfoto/showfoto.h M +101 -78 utilities/imageeditor/editor/editorwindow.cpp M +17 -14 utilities/imageeditor/editor/editorwindow.h M +61 -79 utilities/imageeditor/editor/imagewindow.cpp M +6 -6 utilities/imageeditor/editor/imagewindow.h WebSVN link: http://websvn.kde.org/?view=rev&revision=839320
*** Bug has been marked as fixed ***.
Hi, since I can't start digikam at the moment because of the galleryexport crashes, I can at least tell you about the situation in showfoto: The shortcut Ctrl+T is now reserved for show thumbnails exclusively and works fine. The thumnail bar show/hide feature works here as follows: Apparantly, the bar can be in three different stages: 1) switched off, 2) switched on and visible, and 3) switched on but hidden (retracted). Switching to fullscreen and back again results in 1)->1), 2)->3), 3)->3). The problem I have is the 2)->3) situation, i.e. when the bar is switched on and visible, going to fullscreen and back retracts it, and I have to pull it out with the mouse manually to see it again. Gandalf
This seems only to affect the sidebar if not displayed horizontal. In vertical mode I can confirm this... damn... REOPENING again... :-( Andi
in vertical mode the thumbbar is hidden when returning from fullscreen.
Some brave soul repaired the galleryexport, so I had the chance to check the situation in digikam. Here all works fine now :-), i.e. also 2)->2) (vertical mode). So the remaining problem is a showfoto only issue.
It has not been repaired, we only disable the critical part in the plugin... some KWallet issue is killing all kipi hosting apps. Andi
I have not done anything and it is working right now. I don't understand this... will test a little further...
Sorry for spamming that much right now, but I found the issue: It only happens when the right sidebar is shown. Maybe it is getting too big? Gilles, any idea?
With the right sidebar shown in imageeditor, it can also be confirmed for digiKam...
I'm lost in this report. It still valid ? Gilles
Yes it is, just yesterday I checked it because I thought the bug might be gone when removing the toBase64 methods... but nope, it is still there. So it must be something different (this one is also very annoying, like every splitter bug we have :-)) Andi
I think I found the problem, but I don't know how to handle it. The thumbbar (in ImageEditor or showFoto) disappears after returning from fullscreen, when the SidebarSplitter is calling its setSize() method. Since the thumbbar is no Sidebar widget, it is not getting resized properly. I have put debug messages in setSize() method: digikam(9751)/kfortune Digikam::SidebarSplitter::setSize: SIZELIST: (0, 1440, 0) digikam(9751)/kfortune Digikam::SidebarSplitter::setSize: SIZELIST: (0, 1440, 257) As you can see, only the right item (the Sidebar) is set to its old size, the thumbbar is not. Maybe this bug is also related to the other "famous" spliiter bug? Any suggestions here? Andi
The sidebar explicitly sets its size to the size before hiding. The thumbbar is only shown, which may not be sufficient - perhaps we need to store the size and re-set it after showing again, like it is done for the Sidebar internally. The difference between vertical/horizontal mode is that only with horizontal sidebar there are two splitters, and setting the size of the sidebar does not interfere with the thumbbar.
SVN commit 922871 by mwiesweg: Allow to backup/restore other widgets inside the splitter CCBUG: 166472 M +34 -4 sidebar.cpp M +17 -2 sidebar.h WebSVN link: http://websvn.kde.org/?view=rev&revision=922871
SVN commit 922872 by mwiesweg: Store size of thumbbar and restore when returning from fullscreen. BUG: 166472 M +6 -9 editorwindow.cpp M +2 -0 editorwindowprivate.h WebSVN link: http://websvn.kde.org/?view=rev&revision=922872