Bug 166310 - Preview not working in image effect dialogs
Summary: Preview not working in image effect dialogs
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Plugins (show other bugs)
Version: 0.10.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-11 17:45 UTC by Gandalf Lechner
Modified: 2022-02-03 11:06 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.10.0


Attachments
screenshot (76.07 KB, image/jpeg)
2008-07-11 17:54 UTC, Gandalf Lechner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gandalf Lechner 2008-07-11 17:45:39 UTC
Version:           0.10.0-beta2 (rev.: 830788) (using 4.00.83 (KDE 4.0.83 (KDE 4.1 Beta2), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-19-generic

When applying some effect to a picture, the preview for the result does not work correctly. 

This applies apparantly to all effects using a split original/target preview, e.g. the effects collected in the Color menu. When launching an effect dialog, the "original" half of the preview is there and looks correct, but the "target" part is just missing. Clicking on some of the split options (horizontal, vertical etc) results in showing the "target" half of the preview, but without the effect being applied.

Selecting OK however results in the correct application of the selected effect, just the preview is not working as expected.
Comment 1 Gandalf Lechner 2008-07-11 17:54:37 UTC
Created attachment 26041 [details]
screenshot
Comment 2 Gerhard Kulzer 2008-07-13 11:21:12 UTC
What works is this type of preview:
    Digikam::DImg imDest = m_threadedFilter->getTargetImage();
    m_imagePreviewWidget->setPreviewImage(imDest);

The tape that doesn't work is this:
    Digikam::DImg preview(w, h, sb, a, m_destinationPreviewData);
    Digikam::HSLModifier cmod;
    cmod.setHue(hu);
    cmod.setSaturation(sa);
    cmod.setLightness(lu);
    cmod.applyHSL(preview);
    iface->putPreviewImage(preview.bits());
    m_previewWidget->updatePreview();
Comment 3 Mikolaj Machowski 2008-07-28 16:02:39 UTC
*** Bug 166579 has been marked as a duplicate of this bug. ***
Comment 4 Mikolaj Machowski 2008-07-28 16:03:04 UTC
*** Bug 167563 has been marked as a duplicate of this bug. ***
Comment 5 caulier.gilles 2008-07-31 14:24:54 UTC
SVN commit 840122 by cgilles:

BugFix: do not try to open more than one painter at the same time over a paint device. Qt4.4 sound like more restrictive here.
BUG: 166310


 M  +41 -32    libs/widgets/imageplugins/imageguidewidget.cpp  
 M  +13 -13    libs/widgets/imageplugins/imageguidewidget.h  
 M  +13 -11    project/project.kdevelop  
 M  +13 -6     utilities/imageeditor/editor/imageiface.cpp  
 M  +4 -3      utilities/imageeditor/editor/imageiface.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=840122
Comment 6 Gandalf Lechner 2008-07-31 17:29:00 UTC
Works fine here now, thanks