Bug 165934 - KAnimatedButton doesn't work with Tango throbber
Summary: KAnimatedButton doesn't work with Tango throbber
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kdeui (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-07 12:52 UTC by James Richard Tyrer
Modified: 2009-06-15 00:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Tango throbber PNG file (12.92 KB, image/png)
2008-07-07 12:59 UTC, James Richard Tyrer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Richard Tyrer 2008-07-07 12:52:11 UTC
Version:            (using Devel)
Installed from:    Compiled sources
Compiler:          GCC 4.2.4 
OS:                Linux

There doesn't seem to be a standard for the "process-working" icon file.  The KDE ones are a vertical strip.  However, Tango uses a different format.  A rectangle which I think reads LTR like a page.

Should KAnimatedButton be able to use any format, or is there a standard that needs to be followed?
Comment 1 James Richard Tyrer 2008-07-07 12:59:03 UTC
Created attachment 25896 [details]
Tango throbber PNG file

This is the 32x32 Tango throbber file.

This is 256 x 128 pixels so it is 4 rows of 8 images.
Comment 2 David Faure 2008-07-07 16:47:55 UTC
I'm not aware of a standard.

Is this icon installed into the 32x32 directory? Then I guess KAnimatedButton could figure
out "oh, this big png is 4 rows of 8 images" doing simple division, and go through that.

HOWEVER -- this icon looks like it contains only some overlay, not the full image?
In kolourpaint I only see some [monochrome?] things turning, but with a lot of transparent
pixels, so obviously not suitable as a dropin replacement for the usual kde animated gear...
Comment 3 James Richard Tyrer 2008-07-07 17:15:28 UTC
I think that it just has a clear background.

So, the only thing is that the KAnimatedButton has to have a background.

I opened it in GIMP and put a white layer behind it and it looks OK.
Comment 4 Pino Toscano 2008-10-21 00:02:00 UTC
From what I see from the icon naming spec[1] the animated icon (like "process-working") should be multi-frame PNG, so both KDE and Tango have wrong icons for them.

Anyway, I just committed in KAnimatedButton for KDE 4.2 the support for animated icons (ie MNG files, for example).
When requesting to load an icon with KAnimatedButton, first an animated icon is searched, then the former loading (vertical stip image) is done.
What is missing at this point is just converting our artwork in the animation category as MNG (easy task).

Does it sound ok, or is the support for the Tango tiled image needed yet?

[1] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-0.8.html
Comment 5 James Richard Tyrer 2008-10-21 03:36:36 UTC
It is OK to use MNG if it works smoothly.  I tried an MNG and the KDE-3.5 MNG viewer didn't show it smoothly.

However, the FD.o standard needs to be supported by the code.

There should be no problem doing both since the KDE throbber is branded (process-working-kde) and the Tango one isn't (process-working).
Comment 6 Pino Toscano 2008-10-23 00:23:21 UTC
(In reply to comment #5)
> However, the FD.o standard needs to be supported by the code.

Reread my comment above: since r874171 (two days ago) it is.

> There should be no problem doing both since the KDE throbber is branded
> (process-working-kde) and the Tango one isn't (process-working).

Note we do have an unbranded throbber called "process-working", in a tiled image.
Comment 7 Pino Toscano 2008-12-25 00:43:32 UTC
SVN commit 901284 by pino:

Support tiled animation icons of any grid size (not just 1xN), to be read in an LTR order.
As clarified with Rodney Dawes (dobey).
CCBUG: 165934


 M  +13 -13    kanimatedbutton.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=901284
Comment 8 Dario Andres 2009-06-15 00:02:55 UTC
Fixed by Pino commit