Bug 165288 - Lock/logout buttons are too large if the panel heigth is reduced
Summary: Lock/logout buttons are too large if the panel heigth is reduced
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-29 12:00 UTC by András Manţia
Modified: 2009-03-19 03:00 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
It is the same with vertical panels : you get an enormous lock/logout applet (56.93 KB, image/png)
2008-12-09 08:27 UTC, Tsokar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description András Manţia 2008-06-29 12:00:32 UTC
Version:            (using Devel)
Installed from:    Compiled sources

If the panel height goes below a certain threshold, the buttons are laid out horizontally instead of vertically and they become quite big, taking up a lot of horizontal space. So you gain space on the desktop, but loose space on the panel. :(
Ideas:
- keep the vertical layout as much as possible
- reduce the space between the button in vertical layout to be able to shrink the panel more
- make it configurable to use horizontal/vertical layout
- use smaller icons in horizontal layout (?)
Comment 1 Anne-Marie Mahfouf 2008-06-29 14:11:52 UTC
can you specify your svn revision for kdebase please? thanks in advance!

http://lists.kde.org/?l=kde-commits&m=121457548119303&w=2
should have fixed it, revision 825115

If you have a more recent revision, can you also provide a screenshot please as well as plasma-appletsrc
Comment 2 Loic Marteau 2008-06-29 14:47:58 UTC
Hi Anne-Marie

In fact the author of the bug report talk about the (too big) size of 
the lock/logout icon in panel

Lock logout take less space when panel is big -> lock Logout is 
vertically layouted
than unfortunaly when panel is small -> lock logout horizontally layouted

Since 4.1 lock/logout is horizontal by default.

 > - keep the vertical layout as much as possible
 > - reduce the space between the button in vertical layout to be able 

to shrink the panel more

dont know if it is possible ?!
We already have :
m_layout->setContentsMargins(0,0,0,0);
m_layout->setSpacing(0);

is there other things than we can use to reduce the space ?

 > - make it configurable to use horizontal/vertical layout


if i understand well what we have talked on mailing list lock logout 
will let user to have more actions if he wants, don't know if we should 
add this too for 4.2
 
 > - use smaller icons in horizontal layout (?)


For me this is a generic problem with the size of icons in the panel.
Reduce the size only for this applet will not be very consistent in my 
opinion and we damned all knows that users want  consistencies :D (they 
are right).

We have already talked about that in the desktop (the generic problem, 
no specifically for lock-logout)
The idea is to have something like this
http://nuno-icons.com//images/estilo/imagefolders2.png

I just quote Aaron since he has explain this very well :
 > i think this is really up to the Containment, in this case the Panel, to
 > provide some mechanism for varying the size of select applets. perhaps
 > something like zones of differing height.


 > sebas and alexis have both working on graphics items groupers that 

might be
 > applicable in such situations.

Comment 3 Tsokar 2008-12-09 08:27:42 UTC
Created attachment 29168 [details]
It is the same with vertical panels : you get an enormous lock/logout applet
Comment 4 Tsokar 2008-12-09 08:30:08 UTC
With a full sentence : you get the same annoying problem with vertical panel : an enormous lock/logout applet !

Comment 5 Iuri Fiedoruk 2009-01-28 18:38:55 UTC
This buttons size is really bad for when using KDE in a small form device.
Can't we return to the good and old bahavior of KDE3 - always put two rows when panel space if at least X pixels?  You see, the workplaces areas do that, why the lock/logout buttons can't? And aren't we using SVG to turn those kind of resize possible?

Here is current situation:
http://protomank.googlepages.com/painel1.png

Here is ideal solution:
http://protomank.googlepages.com/painel2.png

Comment 6 Todd 2009-02-19 23:49:21 UTC
The same problem occurs when you have a vertical panel, except that you end up with huge vertical lock/logout buttons instead of huge horizontal ones.  You also cannot get the icons lay out the long way (horizontally on a horizontal panel and vertically on a vertical panel) if your panel is too wide.  So I think the optimal solution is to have an option, with the default being "auto", but also have two other options, "Wide" and "Narrow".  That way, if you move a panel from the bottom or top of the screen to one of the sides, it will keep the same orientation relative to the panel, and not the same orientation relative to the screen.
Comment 7 Nicolas L. 2009-02-27 00:57:27 UTC
this is fixed on kde 4.2.1 , now see :

http://kenobi.mandriva.com/~neoclust/logout.png
Comment 8 Todd 2009-03-19 03:00:38 UTC
What specifically was changed?  I still seem to be having problems in KDE 4.2.1.  Also, the link to the picture doesn't work.