Bug 164949 - Folder View does not perform timely repaint when drag does remove file
Summary: Folder View does not perform timely repaint when drag does remove file
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-folderview (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-25 18:14 UTC by David Benjamin
Modified: 2008-06-25 22:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Benjamin 2008-06-25 18:14:46 UTC
Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

When dragging an icon from a Folder View where the drag does not remove the file (e.g. to the Frame applet or creating a link), the icon does not get repainted until hover.

Patch below results in a repaint regardless of the result of the drag. Alternatively, if (result != Qt::MoveAction) could be used, but I don't know if it's possible to get a Qt::MoveAction and not actually remove the file. A confused client or moving into the same folder, perhaps?


Index: folderview.cpp
===================================================================
--- folderview.cpp      (revision 824074)
+++ folderview.cpp      (working copy)
@@ -1399,10 +1399,8 @@

     m_dragInProgress = false;

-    // Repaint the dragged icons if the drag was canceled
-    if (result == Qt::IgnoreAction) {
-        markAreaDirty(boundingRect);
-    }
+    // Repaint the dragged icons in case the drag did not remove the file
+    markAreaDirty(boundingRect);
 }

 QSize FolderView::iconSize() const
Comment 1 Fredrik Höglund 2008-06-25 22:53:37 UTC
SVN commit 824463 by fredrik:

A successful drop doesn't always mean that the dragged icons are moved out
of the folder, so always repaint the area occupied by the icons after a
drag operation.

Patch by David Benjamin.
BUG: 164949


 M  +3 -5      folderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=824463