Bug 163992 - desktop icon size: provide spinbox instead of combo
Summary: desktop icon size: provide spinbox instead of combo
Status: RESOLVED INTENTIONAL
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_icons (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-13 19:48 UTC by Maciej Pilichowski
Modified: 2019-04-30 18:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (25.17 KB, image/jpeg)
2008-06-14 10:22 UTC, FiNeX
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2008-06-13 19:48:11 UTC
Version:            (using KDE 4.0.82)
Installed from:    Ubuntu Packages

because in this case values are "continuous" and there are too many of them -> thus spinbox is more useful (editbox + ^v widgets).
Comment 1 Pino Toscano 2008-06-13 20:19:13 UTC
Repeat after me: there is NO kdesktop and NO kicker in KDE 4.
Comment 2 Maciej Pilichowski 2008-06-13 20:26:57 UTC
When I type "plasma" I end up with kdestop (thanks to kde bugzilla). It is not my fault, so please, spare the irony.
Comment 3 Maciej Pilichowski 2008-06-13 20:29:34 UTC
I meant "systemsettings", not "plasma" (but I am not sure if the incorrect components are included there as well).
Comment 4 FiNeX 2008-06-14 10:22:41 UTC
Created attachment 25326 [details]
screenshot

Maciej, do you mean this?
Comment 5 Maciej Pilichowski 2008-06-14 10:34:45 UTC
Yes, indeed.
Comment 6 Aaron J. Seigo 2008-06-14 12:40:19 UTC
hmm.. this actually doesn't make any sense: we don't have randomly sized icons. they come in certain well known sizes.

even if we render them directly from the svg on the fly (which still has a number of technical issues, btw) you'll get really nasty results in many cases due to the grid alignment issue (resulting in distorted and blurred icons; it's a math issue)

we offer pre-rendered icons that look good and are designed for those grid sizes. that's why it's a drop down.

so a spin box is rather out; if anything a *slider* would make more sense here.
Comment 7 FiNeX 2008-06-14 12:51:47 UTC
I fully agree with Aaron.
Comment 8 Maciej Pilichowski 2008-06-14 13:01:34 UTC
Aaron, this one kind (only this) is already sized from 20 points to 256 points (with step = 1 pixel). It looks like absurd to change +/-1 point I have to pick up value from the combo.

From what you said I guess, you are talking about fixed set sizes (like 22, 32, 64).

But I fully agree the slider would be great (to be exact: with spinbox, reason, it is not guaranteed you have all values reachable from slider).
Comment 9 Kai Uwe Broulik 2018-04-27 14:32:09 UTC
Git commit 9496728fcb6c012cf1deb773a3d0a5129b4a629e by Kai Uwe Broulik.
Committed on 27/04/2018 at 14:28.
Pushed by broulik into branch 'master'.

[Icon KCM] Port to new design

This completely drops the icon customization with icon effects and only retains the icon size settings.
Should there be any custom icon effects, pressing "Defaults" in the KCM will remove them.
I also couldn't find any trace of that "animations enabled" check box it used to have.
It adds drag and drop support for installing archives as themes. It can also download them from remote location
when dropped from e.g. a browser.

Installing theme files actually never worked in Plasma 5 as it got broken in the port from KIO NetAccess
to storedGet.
An animated preview is also added on hover showing a common selection of icons.

Implements T7262
Related: bug 367619, bug 334301
FIXED-IN: 5.13.0

Differential Revision: https://phabricator.kde.org/D12459

M  +8    -14   kcms/icons/CMakeLists.txt
M  +1    -1    kcms/icons/Messages.sh
D  +0    -716  kcms/icons/icons.cpp
D  +0    -147  kcms/icons/icons.h
A  +205  -0    kcms/icons/iconsmodel.cpp     [License: GPL (v2+)]
A  +84   -0    kcms/icons/iconsmodel.h     [License: GPL (v2+)]
D  +0    -491  kcms/icons/iconthemes.cpp
D  +0    -74   kcms/icons/iconthemes.h
R  +0    -0    kcms/icons/kcm_icons.desktop [from: kcms/icons/icons.desktop - 100% similarity]
M  +493  -48   kcms/icons/main.cpp
M  +75   -18   kcms/icons/main.h
A  +169  -0    kcms/icons/package/contents/ui/IconSizePopup.qml     [License: GPL (v2/3)]
A  +276  -0    kcms/icons/package/contents/ui/main.qml     [License: GPL (v2/3)]
A  +16   -0    kcms/icons/package/metadata.desktop
D  +0    -16   kcms/icons/tests/CMakeLists.txt
D  +0    -16   kcms/icons/tests/testicons.cpp

https://commits.kde.org/plasma-desktop/9496728fcb6c012cf1deb773a3d0a5129b4a629e
Comment 10 Nate Graham 2019-04-30 18:29:41 UTC
The request for a spinbox isn't implementable given how our icons work. They're designed for specific sizes, and a UI to switch between them is best implemented using a combobox, not a spinbox.