Bug 163605 - "article" menu should be disabled if no article is selected
Summary: "article" menu should be disabled if no article is selected
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-09 14:08 UTC by FiNeX
Modified: 2009-03-24 21:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to disable article-related actions when no article is shown (2.24 KB, patch)
2009-03-19 21:37 UTC, Haakon Nilsen
Details
Patch to disable article-related actions when no article is shown (2.25 KB, patch)
2009-03-20 16:25 UTC, Haakon Nilsen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description FiNeX 2008-06-09 14:08:10 UTC
Version:           Revision 818680 (using Devel)
Installed from:    Compiled sources
OS:                Linux

When you start akregator or choose a folder/feed, no articles are selected, so the "Article" menu which contains action related to a selected article, should be disabled.
Comment 1 FiNeX 2008-12-26 21:05:50 UTC
This bug is still valid on trunk and 4.2 beta2.
Comment 2 Haakon Nilsen 2009-03-19 21:37:14 UTC
Created attachment 32268 [details]
Patch to disable article-related actions when no article is shown

The attach patch implements this (works on trunk).

When the about page is shown and a user triggers any article-related action, Akregator crashes. The patch also fixes this by disabling the actions in this situation.
Comment 3 Haakon Nilsen 2009-03-20 16:25:47 UTC
Created attachment 32289 [details]
Patch to disable article-related actions when no article is shown

Updated patch to respect the code style of the project.
Comment 4 Haakon Nilsen 2009-03-21 01:19:43 UTC
Confirmed that patch works both when running as stand-alone and as a part in Kontact.
Comment 5 Frank Osterfeld 2009-03-24 21:59:31 UTC
SVN commit 944014 by osterfeld:

disable article actions if no article is selected
Based on a patch by Haakon Nilsen
BUG:163605


 _M            . (directory)  
 M  +2 -0      akregator/src/actionmanager.h  
 M  +16 -0     akregator/src/actionmanagerimpl.cpp  
 M  +7 -5      akregator/src/actionmanagerimpl.h  
 M  +10 -0     akregator/src/articleviewer.cpp  
 M  +2 -0      akregator/src/articleviewer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=944014