Bug 162812 - Sharpen slider enhancement refresh previews continuously
Summary: Sharpen slider enhancement refresh previews continuously
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Sharpen (show other bugs)
Version: 0.9.4
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-29 14:52 UTC by Mark Purcell
Modified: 2017-08-07 07:18 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.4
Sentry Crash Report:


Attachments
fixes continuous rendering of filter (30.55 KB, patch)
2008-07-09 18:45 UTC, Andi Clemens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Purcell 2008-05-29 14:52:42 UTC
Version:           0.9.4-beta5 (using 3.5.9, Debian Package 4:3.5.9.dfsg.1-4 (lenny/sid))
Compiler:          Target: powerpc-linux-gnu
OS:                Linux (ppc) release 2.6.18-5-powerpc

This is a forwarded report from:

http://bugs.debian.org/433116

I confirm this is still an issue with 0.9.4-beta5.

A better explanation of this issue, is that when using the Sharpen slider, the sharpen transformation is started before the slider is released.

Thus it is impossible to drag the slider slowly from one extreme to the other slowly, as it commences the transform before the slider is released.  The user then needs to await the completion of the transform ( a couple of seconds at least) until one can continue sliding.

Mark

From: Jiří Paleček <jpalecek@web.de>
To: "Debian Bug Tracking System" <submit@bugs.debian.org>
Subject: digikam: plugins refresh previews continuously
Date: Sat, 14 Jul 2007 16:46:29 +0200

Package: digikam
Version: 2:0.9.2-3
Severity: normal

Hello,

some plugins (eg. sharpen) refresh the preview continuously. This is
bad, because it makes the UI almost unusable. For example, buttons
become disabled and then reenabled every 1/2 seconds, which makes it
very hard, if not impossible, to click on them.

Regards
    Jiri Palecek

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.20.3-rt8 (PREEMPT)
Locale: LANG=cs_CZ, LC_CTYPE=cs_CZ (charmap=ISO-8859-2) (ignored: LC_ALL  
set to cs_CZ)
Shell: /bin/sh linked to /bin/dash

Versions of packages digikam depends on:
ii  kdebase-kio-plugins     4:3.5.7-1        core I/O slaves for KDE
ii  kdelibs4c2a             4:3.5.7.dfsg.1-1 core libraries and binaries  
for al
ii  libacl1                 2.2.42-1         Access control list shared  
library
ii  libart-2.0-2            2.3.19-3         Library of functions for 2D  
graphi
ii  libattr1                1:2.4.32-1.1     Extended attribute shared  
library
ii  libaudio2               1.9-2            The Network Audio System  
(NAS). (s
ii  libc6                   2.6-0exp3        GNU C Library: Shared  
libraries
ii  libexif12               0.6.15-1         library to parse EXIF files
ii  libexiv2-0              0.14-2           EXIF/IPTC metadata  
manipulation li
ii  libfontconfig1          2.4.2-1.2        generic font configuration  
library
ii  libfreetype6            2.2.1-6          FreeType 2 font engine,  
shared lib
ii  libgamin0 [libfam0]     0.1.8-2          Client library for the gamin  
file
ii  libgcc1                 1:4.2-20070627-1 GCC support library
ii  libgphoto2-2            2.3.1-5          gphoto2 digital camera library
ii  libgphoto2-2-dev        2.3.1-5          gphoto2 digital camera  
library (de
ii  libgphoto2-port0        2.3.1-5          gphoto2 digital camera port  
librar
ii  libice6                 1:1.0.3-2        X11 Inter-Client Exchange  
library
ii  libidn11                0.6.5-1          GNU libidn library,  
implementation
ii  libjasper1              1.900.1-3        The JasPer JPEG-2000 runtime  
libra
ii  libjpeg62               6b-13            The Independent JPEG Group's  
JPEG
ii  libkdcraw1              0.1.1-2          Raw picture decoding  
C++ library (
ii  libkexiv2-1             0.1.5-1+b1       Qt like interface for the  
libexiv2
ii  libkipi0                0.1.5-2          library for apps that want to  
use
ii  liblcms1                1.16-5           Color management library
ii  libltdl3                1.5.22-4         A system independent dlopen  
wrappe
ii  libpcre3                6.7-1            Perl 5 Compatible Regular  
Expressi
ii  libpng12-0              1.2.15~beta5-2   PNG library - runtime
ii  libqt3-mt               3:3.3.7-4+b1     Qt GUI Library (Threaded  
runtime v
ii  libsm6                  2:1.0.3-1        X11 Session Management library
ii  libsqlite3-0            3.3.17-1         SQLite 3 shared library
ii  libstdc++6              4.2-20070627-1   The GNU Standard C++ Library  
v3
ii  libtiff4                3.8.2-7          Tag Image File Format (TIFF)  
libra
ii  libx11-6                2:1.0.3-7        X11 client-side library
ii  libxcursor1             1:1.1.8-2        X cursor management library
ii  libxext6                1:1.0.3-2        X11 miscellaneous extension  
librar
ii  libxft2                 2.1.12-2         FreeType-based font drawing  
librar
ii  libxi6                  1:1.0.1-4        X11 Input extension library
ii  libxinerama1            1:1.0.2-1        X11 Xinerama extension library
ii  libxrandr2              2:1.2.1-1        X11 RandR extension library
ii  libxrender1             1:0.9.2-1        X Rendering Extension client  
libra
ii  libxt6                  1:1.0.5-3        X11 toolkit intrinsics library
ii  zlib1g                  1:1.2.3.3.dfsg-3 compression library - runtime

Versions of packages digikam recommends:
ii  kdeprint                      4:3.5.7-1  print system for KDE
ii  kipi-plugins                  0.1.4-1+b1 image manipulation/handling  
plugin
ii  konqueror                     4:3.5.7-1  KDE's advanced file manager,  
web b

-- no debconf information
Comment 1 Andi Clemens 2008-07-09 18:43:01 UTC
Yes, it is true, right now sharpening filter is unusable (and so is blur). Today I needed to scan some images and they all were too blurry. So I had to sharpen them a little bit, but every time I change a filter setting or try to zoom in, it is calculating. I always have to click abort immediately. The same for the blur filter (and maybe others, I have not checked yet).
If you compare 'sharpening' with 'restoration', you can see the differences.
I just changed the behavior of 'sharpen' to those of 'restoration'.
I'll attach the patch.
Comment 2 Andi Clemens 2008-07-09 18:45:09 UTC
Created attachment 25992 [details]
fixes continuous rendering of filter

With this patch you can set your settings and hit "Try" to check them. Now it
is possible to zoom and change things like you want to...
This has to be applied for blur, too... and maybe other filters.
It is really a huge slowdown, right now I was not able to work with digiKam...
so I changed it immediately :-)

Gilles,

what do you think?
Comment 3 caulier.gilles 2008-07-09 18:56:27 UTC
Andi,

yes, patch is right, and of course, need to be backported to KDE4

Gilles
Comment 4 Andi Clemens 2008-07-09 19:05:45 UTC
Also the Abort button is enabled in every filter by default, but this is not true. I will disable it in CtrlDlg class. But I have to check first with every filter inherited from CtrlDlg...
Comment 5 Andi Clemens 2008-07-09 19:24:41 UTC
SVN commit 830068 by aclemens:

backport commit #830067 from KDE3 branch
CCBUGS:162812

 M  +3 -0      ctrlpaneldlg.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=830068
Comment 6 Andi Clemens 2008-07-09 20:06:39 UTC
SVN commit 830084 by aclemens:

added "Try" button to this filter dialog to avoid filter rendering on every settings change or zoom action.

 M  +289 -319  imageeffect_sharpen.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=830084
Comment 7 Andi Clemens 2008-07-09 20:18:28 UTC
SVN commit 830090 by aclemens:

backport commit #830084 from KDE3 branch
CCBUGS:162812

 M  +288 -318  imageeffect_sharpen.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=830090
Comment 8 Andi Clemens 2008-07-09 20:20:59 UTC
I will add this behavior to all the other filters depending on CtrlPanelDlg as well:

blurfx
infrared
oilpaint
texture
charcoal
filmgrain
emboss
restoration
noise reduction
hotpixels
blur