Bug 162206 - WISH: case sensitivity in the text quick filter
Summary: WISH: case sensitivity in the text quick filter
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Filters (show other bugs)
Version: 0.9.4
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-17 13:01 UTC by Lawrence Plug
Modified: 2008-12-22 23:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Plug 2008-05-17 13:01:15 UTC
Version:           0.9.4 (using KDE 3.5.9)
Installed from:    Ubuntu Packages
OS:                Linux

The text quick-filter search box would be more useful if it were case sensitive. This would allow, for example, to discriminate between *.jpg and *.JPG files (where one is the camera jpeg image and the other is produced by a raw converter).
Comment 1 Arnd Baecker 2008-05-17 13:12:40 UTC
Most likely, this should be made configurable - 
what do you think Lawrence, Gilles?
Could one add something like this to the right-mouse-button pop-up
for the text-field of the search box?
Comment 2 caulier.gilles 2008-05-17 13:40:04 UTC
Arnd,

I'm totally agree with your proposal. Like this, we can add later more option to perform text filtering, if necessary.

Gilles
Comment 3 Lawrence Plug 2008-05-17 14:15:51 UTC
Optional would be best - total agreement from me.

cheers
Comment 4 Arnd Baecker 2008-05-17 14:47:24 UTC
On the technical side, there are two things:
a) In kio digikamalbums.cpp:  there is the routine 
      makeFilterList( const QString &filter )
   which calls regExps << QRegExp( (*it).stripWhiteSpace(), false, true );
   Setting the "false" to "true" corresponds to a case sensitive search.

   So in kio_digikamalbums::special(const QByteArray& data) 
   a new  element (e.g. `caseSensitive`) for `QDataStream ds` has to be
   added. If I remember correctly, one has to be careful when adding
   stuff here due to the serial protocol ...

b) add a new entry to the pop-up and a new configuration option to
   save this setting

While a) seems pretty straightforward, I am not sure about b),
i.e. whether one can easily sub-class the pop-up menu
and simply add a new entry?
Comment 5 Mikolaj Machowski 2008-05-17 19:49:23 UTC
As an exemple of interface for this I'd like to point to KPDF. There is
small button with appearing menu with options:

Case sensitive
--------------
Match phrase
Match all words
Match any word

It means there is possibility of combination case sensitive + match
phrase or case insensitive + match any word.
Comment 6 caulier.gilles 2008-12-05 22:00:58 UTC
Arnd,

Any progress with this file ?

Gilles Caulier
Comment 7 caulier.gilles 2008-12-22 23:03:57 UTC
SVN commit 900460 by cgilles:

digiKam from trunk : add new option to match search text bar everywhere in sensitive case or not.
The option is in context menu of search text bar where user enter string to match.
By default, the option is dsable.
BUG: 162206
BUG: 177329


 M  +7 -8      digikam/albumfolderview.cpp  
 M  +2 -1      digikam/albumfolderview.h  
 M  +4 -5      digikam/albumiconviewfilter.cpp  
 M  +2 -1      digikam/albumiconviewfilter.h  
 M  +10 -10    digikam/albumlister.cpp  
 M  +2 -1      digikam/albumlister.h  
 M  +7 -9      digikam/albumselectdialog.cpp  
 M  +5 -1      digikam/albumselectdialog.h  
 M  +15 -16    digikam/digikamview.cpp  
 M  +1 -0      digikam/digikamview.h  
 M  +7 -8      digikam/tagfilterview.cpp  
 M  +2 -1      digikam/tagfilterview.h  
 M  +7 -8      digikam/tagfolderview.cpp  
 M  +2 -1      digikam/tagfolderview.h  
 M  +5 -9      libs/dialogs/rawcameradlg.cpp  
 M  +2 -1      libs/dialogs/rawcameradlg.h  
 M  +13 -14    libs/imageproperties/imagedescedittab.cpp  
 M  +3 -2      libs/imageproperties/imagedescedittab.h  
 M  +33 -2     libs/widgets/common/searchtextbar.cpp  
 M  +28 -1     libs/widgets/common/searchtextbar.h  
 M  +4 -4      libs/widgets/metadata/metadatalistview.cpp  
 M  +2 -1      libs/widgets/metadata/metadatalistview.h  
 M  +3 -3      libs/widgets/metadata/metadatawidget.cpp  
 M  +3 -1      project/project.kdevelop  
 M  +3 -4      utilities/fuzzysearch/fuzzysearchfolderview.cpp  
 M  +2 -1      utilities/fuzzysearch/fuzzysearchfolderview.h  
 M  +2 -2      utilities/fuzzysearch/fuzzysearchview.cpp  
 M  +4 -5      utilities/gpssearch/gpssearchfolderview.cpp  
 M  +2 -1      utilities/gpssearch/gpssearchfolderview.h  
 M  +2 -2      utilities/gpssearch/gpssearchview.cpp  
 M  +21 -25    utilities/kipiiface/kipiimagecollectionselector.cpp  
 M  +4 -3      utilities/kipiiface/kipiimagecollectionselector.h  
 M  +9 -11     utilities/kipiiface/kipiuploadwidget.cpp  
 M  +2 -1      utilities/kipiiface/kipiuploadwidget.h  
 M  +3 -4      utilities/searchwindow/searchfolderview.cpp  
 M  +2 -1      utilities/searchwindow/searchfolderview.h  
 M  +5 -6      utilities/setup/cameraselection.cpp  
 M  +5 -1      utilities/setup/cameraselection.h  
 M  +3 -4      utilities/timeline/timelinefolderview.cpp  
 M  +2 -1      utilities/timeline/timelinefolderview.h  
 M  +2 -2      utilities/timeline/timelineview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=900460