Bug 161990 - icon loader no longer finds koffice icons.
Summary: icon loader no longer finds koffice icons.
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
: 164388 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-12 09:56 UTC by Thomas Zander
Modified: 2008-07-21 19:52 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix the loading (464 bytes, patch)
2008-07-19 08:08 UTC, Cyrille Berger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander 2008-05-12 09:56:54 UTC
Version:            (using Devel)
Installed from:    Compiled sources

Some weeks ago, in kdelibs trunk, loads of koffice icons started to be replaced with 'not-found' icons and we now get;
kword(7599)/kdeui (KIconLoader) KIconLoader::loadIcon: No such icon "music-note-16th"
on screen.

KOffice uses
  KIconLoader::global()->addAppDir("koffice");
and installs its icons in places like;

/usr/local/kde/share/apps/koffice/icons/hicolor/22x22/actions/music-note-16th.png
/usr/local/kde/share/apps/koffice/icons/oxygen/22x22/actions/callout-shape.png

where /usr/local/kde/ is my KDEDIR.

Since this used to work in kde3 and kde4.0.0 I'm wondering what changed.
Comment 1 Halla Rempt 2008-05-16 23:11:59 UTC
Me too...
Comment 2 Thomas Zander 2008-06-19 09:57:52 UTC
*** Bug 164388 has been marked as a duplicate of this bug. ***
Comment 3 Cyrille Berger 2008-07-16 10:32:15 UTC
Most likely caused by r794709, if someone can test ? It looks like the only potentially harmfull change in KIconLoad.

Looking at it, it might be caused by the change in KIconLoaderPrivate::addAppThemes. In the previous revision, it was adding both currentTheme and defaultTheme, while now, it adds only either current or default.
Comment 4 Cyrille Berger 2008-07-19 08:08:49 UTC
Created attachment 26250 [details]
Fix the loading

This fix the bug, but you have to nuke your icon cache (the only way I know to
do that is to rm ~/.kde[ |4] ). On the other hand, since I don't know what the
code is supposed to do, I am not sure if it is the good fix, but previous
revision didn't do that check.
Comment 5 Michael Pyne 2008-07-19 22:36:50 UTC
It's safest to nuke the cache outside of KDE due to the mmap()'ing which is used.  It's in /var/tmp/kdecache-$USER/kpc/kde-icon-cache* on my system, may be different on yours depending on if you have a different KDE_VARTMP (IIRC) env setting.
Comment 6 Cyrille Berger 2008-07-21 19:48:55 UTC
SVN commit 836082 by berger:

fix icon loading for custom theme of application
CCBUG: 161990



 M  +2 -2      icons/kiconloader.cpp  
 M  +6 -1      tests/kiconloader_unittest.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=836082
Comment 7 Cyrille Berger 2008-07-21 19:52:32 UTC
SVN commit 836083 by berger:

backport 836082, fix icon loading for custom theme of application 
BUG: 161990


 M  +2 -2      kiconloader.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=836083