Version: (using Devel) Installed from: Compiled sources OS: Linux Currently, if I set a status message while "Online", other AIM users cannot see it. Similarly, if an AIM contact on my buddy list has an online status set, I cannot see it. Kopete should support these "online" status messages. If a Kopete dev can give me a (fairly specific) idea of what needs to be done, and be available for questions, I will try to write a patch.
Created attachment 29086 [details] Implement AIM available messages The attached patch (based against trunk kdenetwork/kopete) implements support for available messages on AIM. Unfortunately, the patch touches common OSCAR code, and since I don't have an ICQ account, I have no easy way to test it to make sure it doesn't cause any regressions there. Please review, test (especially ICQ) and commit if it looks good. This is my first time digging around inside Kopete, so I'm sure it could probably be improved. Also, I realize this probably won't make it in for KDE 4.2 as it's a wishlist, but if it could for 4.3 that would be great. Thanks!
Created attachment 30158 [details] AIM availabe messages (v2) Updated patch that compiles against trunk. Now that trunk is open for new features, can this be reviewed/committed? Thanks!
I'll look at it over weekend, from the first look the change in oscarcontact may break ICQ status messages/title.
I can try moving that into aimcontact.cpp if you feel it's safer. Just reading through icqcontact.cpp, however, I think it should be OK where it is. ICQContact::userInfoUpdated() calls refreshStatus() immediately after OscarContact::userInfoUpdated(). In refreshStatus(), we will set or remove mProtocol->statusTitle in any case. Assuming I'm reading this correctly, that means the ICQ status information would take precedence, yes?
SVN commit 912549 by rjarosz: Fix bug 161464: Support AIM "Available" status messages Based on patch provided by Josh Berry, thanks! BUG: 161464 M +3 -9 aim/aimcontact.cpp M +3 -9 aim/icqcontact.cpp M +3 -9 icq/aimcontact.cpp M +3 -1 liboscar/client.cpp M +1 -1 liboscar/tasks/senddcinfotask.cpp M +1 -1 liboscar/tasks/senddcinfotask.h M +2 -2 liboscar/userdetails.cpp M +2 -2 liboscar/userdetails.h WebSVN link: http://websvn.kde.org/?view=rev&revision=912549
Thanks for committing!
It looks like you reworked it a fair amount. Just for my future reference, and if you have time, would you mind going through your changes with me? I'd like to understand what I could have done better. If you'd rather not pollute the bug with it, feel free to send me email and we can review it some other way. Thanks!