Bug 160885 - [PATCH] Verification of PGP signatures broken
Summary: [PATCH] Verification of PGP signatures broken
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: encryption (show other bugs)
Version: SVN trunk (KDE 4)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-16 00:11 UTC by Onno Molenkamp
Modified: 2008-05-02 18:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Suggested fix for bug 160885 (872 bytes, patch)
2008-04-16 00:13 UTC, Onno Molenkamp 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Onno Molenkamp 2008-04-16 00:11:43 UTC 
Version:            (using Devel)
Installed from:    Compiled sources
Compiler:          gcc version 4.2.1 (SUSE Linux) 
OS:                Linux

On every PGP-signed message, I'm getting an "Not enough information to check signature validity." message which expands to:

Message was signed with unknown key.
The validity of the signature cannot be verified.
Status: Error: Signature not verified

This is caused by gpg returning an error (verify signatures failed: Unknown system error) which is caused by kmail not passing any signature to it. It looks like this is caused by a change in kdepim/kmail/objecttreeparser.cpp in SVN revision 463791 (in 2005, shortly after 3.5 was branched!) that accidentally removed the line from ObjectTreeParser::writeOpaqueOrMultipartSignedData that set the variable signaturetext that is used later on in this method as a parameter to the actual verification method.
Comment 1 Onno Molenkamp 2008-04-16 00:13:16 UTC 
Created attachment 24351 [details]
Suggested fix for bug 160885
Comment 2 Thomas McGuire 2008-05-02 18:31:33 UTC 
This bug is fixed in trunk revision 803023.
See http://websvn.kde.org/?view=rev&revision=803023 .

Thanks for the patch, but the merge in that commit also fixed it.