Bug 159981 - does not correctly use the file: "panel-background.svg"
Summary: does not correctly use the file: "panel-background.svg"
Status: RESOLVED WORKSFORME
Alias: None
Product: plasma4
Classification: Plasma
Component: panel (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-27 23:39 UTC by James Richard Tyrer
Modified: 2008-04-02 06:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Current SVG file for Panel background (16.04 KB, image/svg+xml)
2008-03-27 23:41 UTC, James Richard Tyrer
Details
"panel-background.svg" with square ends. (8.15 KB, image/svg+xml)
2008-03-28 03:55 UTC, James Richard Tyrer
Details
corrected (10.00 KB, image/svg+xml)
2008-04-01 07:24 UTC, James Richard Tyrer
Details
"panel-background.svg" file that works in all positions and lengts (7.95 KB, image/svg+xml)
2008-04-01 23:48 UTC, James Richard Tyrer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Richard Tyrer 2008-03-27 23:39:06 UTC
Version:            (using KDE 4.0.2)
Installed from:    Compiled From Sources
Compiler:          GCC-4.2.3 
OS:                Linux

The Plasma Panel code appears to have been hacked to remove the curved ends rather than changing the SVG file.  See attachment.

So, now, it is not possible to theme the ends of the Panel.
Comment 1 James Richard Tyrer 2008-03-27 23:41:36 UTC
Created attachment 24096 [details]
Current SVG file for Panel background
Comment 2 Chani 2008-03-28 00:08:46 UTC
no, it doesn't *have* ends because it takes the full width/height of the screen. if there were ends, they would be offscreen where you wouldn't see them.
support for non-full-width panels will come eventually.
Comment 3 James Richard Tyrer 2008-03-28 03:27:52 UTC
When the Panel functions properly so that its length can be varied, then it will have ends.  So, the original code was correct and what the ends look like should be determined by the SVG file.  As it is, the Panel is violating the standards for Plasma themes.
Comment 4 James Richard Tyrer 2008-03-28 03:55:18 UTC
Created attachment 24097 [details]
"panel-background.svg" with square ends.

There is perhaps an issue with how wide the "left" and " right" objects should
be.
Comment 5 James Richard Tyrer 2008-04-01 07:24:01 UTC
Created attachment 24143 [details]
corrected

Actually this won't work either since the Panel needs to be correctly themed in
all 4 positions.
Comment 6 Aaron J. Seigo 2008-04-01 07:43:35 UTC
it's optional to be themed in all 4 positions, you can also just have a symmetrical design that works on all positions. the 4 theming system only matters if your light source direction needs to change as well.

anyways, the panel code is indeed correct. we don't do end caps on screen edges, due to margins and fitts law.

it is arguable that on no margin designs we should show the edges, however that means we behave differently depending on that hint, and we'd like to keep the consistency instead.
Comment 7 James Richard Tyrer 2008-04-01 23:44:57 UTC
I appear to have misunderstood the problem that I was having trying to change the Panel theme.

The code in Trunk does appear to handle this correctly using the length without ends so that the ends disappear when the panel is full width.

The problem actually appears to be the the file "panel-background.svg" which was only designed for a bottom Panel and does not produce a correct boarder in the other positions.
Comment 8 James Richard Tyrer 2008-04-01 23:48:30 UTC
Created attachment 24151 [details]
"panel-background.svg" file that works in all positions and lengts

This works for me.  If OK, please commit.
Comment 9 Aaron J. Seigo 2008-04-02 03:34:16 UTC
this was actually reported in another BR which is now in the oxygen product iirc. anyways, you have an svn account, correct? (i see in the accounts list still.) the change to the svg looks fine, so if you'd like you can commit it (always nicer to let the individual who does the fix commit it =)

if for some reason can't, let me know.
Comment 10 James Richard Tyrer 2008-04-02 05:05:06 UTC
SVN commit 792768 by tyrerj:

CCBUG: 159981

"Default" style Panel Backgroung SVG file modified to have the same boarder on all 4 sides so that it has a boarder when used in all 4 edges of the screen.

 M  +170 -365  panel-background.svg  


WebSVN link: http://websvn.kde.org/?view=rev&revision=792768
Comment 11 James Richard Tyrer 2008-04-02 06:19:41 UTC
r792769 | tyrerj | 2008-04-01 20:09:33 -0700 (Tue, 01 Apr 2008) | 3 lines

BUG: 159981

Revision 792768 backported to Branch.