Bug 159295 - Move a tab in the tablist using Ctrl+Shift+Left Arrow/Right Arrow lose the focus of the current tab
Summary: Move a tab in the tablist using Ctrl+Shift+Left Arrow/Right Arrow lose the fo...
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 4.0.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 75819 185259 200781 236988 238635 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-14 11:27 UTC by Nicolas Ternisien
Modified: 2012-01-19 20:58 UTC (History)
14 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Ternisien 2008-03-14 11:27:46 UTC
Version:            (using KDE 4.0.2)
Installed from:    Ubuntu Packages
OS:                Linux

How to reproduce :

- Open 3 tabs, on 3 different web sites (to see the difference).
- Select the last one.
- Use Ctrl+Shift+Left Arrow

The tab moves properly, but the focus is transmitted to the location bar. So you are unable to move this tab again to the left. Conclusion : You have to move your tab using this shortcut by 1 step at once.
To re-be able to move it to the left, you need to click on another tab, then the wanted-to-move one, and reuse the Ctrl+Shift+Left Arrow shortcut.

This is a little bit annoying.
Comment 1 FiNeX 2008-03-14 12:05:31 UTC
Bug confirmed on revision 785508.
Comment 2 Rui G. 2008-05-24 12:40:16 UTC
Still confirmed in trunk revision 811411.
Comment 3 Steve Hay 2008-06-26 01:26:23 UTC
Still confirmed in revision 823138.
Comment 4 Dario Andres 2009-02-22 19:32:36 UTC
*** Bug 185259 has been marked as a duplicate of this bug. ***
Comment 5 Frank Reininghaus 2009-07-19 19:25:57 UTC
*** Bug 200781 has been marked as a duplicate of this bug. ***
Comment 6 A. Spehr 2009-07-19 20:17:25 UTC
It may take more than three tabs to show this reliably, apparently.
Comment 7 Jedd 2009-12-16 15:50:48 UTC
Still here with KDE 4.2.4 (as packaged in Debian unstable)

Is it a genuinely tricky thing to fix, or just a really low priority?  It's not something I use *a lot* but it's been irritating me since I hopped onto KDE 4 about a 12 months ago - and the bug has been known for 20+ months now.
Comment 8 squan 2010-01-23 20:44:51 UTC
Organizying tabs with a keyboard shortcut is a nice feature (one of these which make konqueror distinct) and my workaround is to temporarily hide the address bar (just Alt-E-W-A with german UI).
Comment 9 David Faure 2010-04-03 00:09:04 UTC
Currently debugging this one, actually. Comes from KTabWidget::moveTab calling removeTab+insertTab, which moves the focus to the next focusable widget, which can be the location bar in some cases. Wrote unittests for it, next step is to try porting that code to QTabBar::moveTab...
Comment 10 David Faure 2010-04-03 00:18:25 UTC
QTabBar::moveTab doesn't help, because QTabWidgetPrivate::_q_tabMoved still calls removeWidget+insertWidget in the QStackedWidget -> the focus changes.
Maybe this should actually be fixed in Qt...
Comment 11 David Faure 2010-04-03 01:26:23 UTC
SVN commit 1110400 by dfaure:

Fix "Move a tab in the tablist using Ctrl+Shift+Left Arrow/Right Arrow lose the focus of the current tab".

This was due to KTabWidget::moveTab calling removeTab+insertTab, and removeTab hides the widget,
which moves the focus to the next focusable widget, which can be the location bar in some cases.
Interestingly enough, QTabBar::moveTab has the same problem...

Fixed for: 4.4.3 (I'll backport)
BUG: 159295


 M  +46 -17    tests/ktabwidget_unittest.cpp  
 M  +24 -1     widgets/ktabwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1110400
Comment 12 David Faure 2010-04-03 01:42:02 UTC
http://bugreports.qt.nokia.com/browse/QTBUG-9604 filed about QTabBar/QTabWidget having the same problem.
Comment 13 Frank Reininghaus 2010-05-10 17:45:42 UTC
*** Bug 236988 has been marked as a duplicate of this bug. ***
Comment 14 Frank Reininghaus 2010-05-26 15:53:24 UTC
*** Bug 238635 has been marked as a duplicate of this bug. ***
Comment 15 David Faure 2010-08-18 02:10:16 UTC
SVN commit 1164923 by dfaure:

Simplify the code using isAncestorOf which I hadn't noticed at the time (thanks André!)
CCBUG: 159295


 M  +1 -14     ktabwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1164923
Comment 16 Dawit Alemayehu 2012-01-19 20:58:51 UTC
*** Bug 75819 has been marked as a duplicate of this bug. ***