Bug 158444 - Pager can't display name of desktop as text over miniature of desktop
Summary: Pager can't display name of desktop as text over miniature of desktop
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-26 12:01 UTC by Rafał Miłecki
Modified: 2008-04-22 19:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Miłecki 2008-02-26 12:01:53 UTC
Version:            (using KDE 4.0.0)
Installed from:    SuSE RPMs

I can make pager display number of desktop but name is not possible to choose. I wish to see name of each desktop over it's miniature in applet.

What we must consider when adding this is:
1) New combobox in settings instead of current checkbox
2) Names are usually quite long, at least longer than width of miniature of desktop. We should increase width of miniature to the width of longest name. Although we shouldn't do that when panel is on left or right because space is quite limited then.
3) When calculating width of miniature we should add some additional pixels to add margin between text and borders
4) Since we increase only one dimension, we have to split m_scaleFactor into m_widthScaleFactor and m_heightScaleFactor
Comment 1 Rafał Miłecki 2008-02-26 13:50:33 UTC
I'm working on patch for this, 50% work is done. Will post patch when ready (about week I hope).
Comment 2 Anne-Marie Mahfouf 2008-03-14 21:37:44 UTC
Patch by Rafał Miłecki  committed
http://lists.kde.org/?l=kde-commits&m=120552598704669&w=2

Thanks Rafał!
Comment 3 Patrick O'Callaghan 2008-04-22 17:25:14 UTC
Just like to add that this is a fairly major usability bug for me. I use desktop names all the time in KDE 3.5 and not having them in the pager is a real bummer.
Comment 4 Rafał Miłecki 2008-04-22 18:42:37 UTC
Patrick O'Callaghan: I'm glad my fix was useful :) Patch was applied to trunk branch so you may be 99% sure to see this feature in KDE 4.1.