Bug 158355 - Manage Profiles "Show in Menu" messed up for first entry
Summary: Manage Profiles "Show in Menu" messed up for first entry
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-24 20:31 UTC by Majin Sniper
Modified: 2008-03-23 12:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Original State (first entry shown in Menu, second not) (22.65 KB, image/png)
2008-02-24 20:32 UTC, Majin Sniper
Details
Same state as the first shot, but first entry in the list selected and the star symbol is invisible (22.08 KB, image/png)
2008-02-24 20:33 UTC, Majin Sniper
Details
First entry not shown in Menu anymore but the second, the manage profiles window looks like this when it is closed and reopened (23.31 KB, image/png)
2008-02-24 20:34 UTC, Majin Sniper
Details
The Menu matching shot 3 (14.90 KB, image/png)
2008-02-24 20:36 UTC, Majin Sniper
Details
screenshot of the konsole profile dialog (17.89 KB, image/jpeg)
2008-03-23 01:44 UTC, FiNeX
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Majin Sniper 2008-02-24 20:31:14 UTC
Version:            (using Devel)
Installed from:    Compiled sources
Compiler:          gcc 4.1.2 from Gentoo eBuild
OS:                Linux

In the "Manage Profiles" Dialog, the "Show in Menu" Option is somehow broken:
- The star symbol disappears, when an entry is selected (Screenshots 1 and 2). This is not limited to the Oxygen it appaers at least in Plastik style as well.
- The option for the first entry can only be switched off and not back on.
- The star of the first entry appears when opening the profiles windows, no matter if the entry is shown in the menu or not (See Screenshots 3 and 4)
Comment 1 Majin Sniper 2008-02-24 20:32:23 UTC
Created attachment 23699 [details]
Original State (first entry shown in Menu, second not)
Comment 2 Majin Sniper 2008-02-24 20:33:09 UTC
Created attachment 23700 [details]
Same state as the first shot, but first entry in the list selected and the star symbol is invisible
Comment 3 Majin Sniper 2008-02-24 20:34:28 UTC
Created attachment 23701 [details]
First entry not shown in Menu anymore but the second, the manage profiles window looks like this when it is closed and reopened
Comment 4 Majin Sniper 2008-02-24 20:36:08 UTC
Created attachment 23702 [details]
The Menu matching shot 3
Comment 5 FiNeX 2008-02-26 13:46:54 UTC
Confirmed, the "show in menu" option is not working right.
Comment 6 FiNeX 2008-02-26 13:47:18 UTC
Please vote for this bug! :-)
Comment 7 Robert Knight 2008-03-23 01:03:51 UTC
Hi Finex,

I think I fixed all of these.  Can you please check r788961 or later?
Comment 8 FiNeX 2008-03-23 01:43:43 UTC
Hi Robert. I've tested it. Actually it works better. There is only an issue: when I select a line, the "star" on the "show in menu" colum disappear. I'll attach a screenshot.
Comment 9 FiNeX 2008-03-23 01:44:43 UTC
Created attachment 24006 [details]
screenshot of the konsole profile dialog

The "star" on the "show in menu" field is not visible on the selected line.
Comment 10 FiNeX 2008-03-23 01:50:38 UTC
Ok, I've updated the code from SVN again. And now the star is visible :-)

... Robert, could you center the star on the column? :-)

Thanks!
Comment 11 Robert Knight 2008-03-23 01:58:26 UTC
> ... Robert, could you center the star on the column? :-) 

I need to get in touch with the Trolls about combining custom rendering with styled item delegates in Qt 4.4 first.

Comment 12 FiNeX 2008-03-23 12:45:18 UTC
dont' worry... :-)