Bug 158320 - Add importing of plain URL lists
Summary: Add importing of plain URL lists
Status: RESOLVED FIXED
Alias: None
Product: kget
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: KGet authors
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-24 11:38 UTC by LXj
Modified: 2008-05-01 13:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
kget import (72.76 KB, image/jpeg)
2008-04-23 01:01 UTC, FiNeX
Details
patch to allow write the regular expression in the configuration (3.75 KB, patch)
2008-04-23 09:47 UTC, Javier goday
Details

Note You need to log in before you can comment on or make changes to this bug.
Description LXj 2008-02-24 11:38:18 UTC
Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

I have a file with a list of URL separated by newlines, and I found no way of importing it as a list of downloads. Please add support of such lists!
Comment 1 LXj 2008-02-24 11:42:19 UTC
Also there should be a way of importing such a list from clipboard
Comment 2 FiNeX 2008-03-23 01:35:36 UTC
This feature could be very useful.
Usually I use:
  wget -i filename
It should be implemented something similar in kget on "File->Import transfers"
Comment 3 Javier goday 2008-04-19 15:46:47 UTC
SVN commit 798793 by jgoday:

Added option to import links from a file or an url using the 
extensions/konqueror/kget_linkview ui
BUG:158320


 M  +2 -0      CMakeLists.txt  
 A             core/linkimporter.cpp   [License: GPL (v2+)]
 A             core/linkimporter.h   [License: GPL (v2+)]
 M  +0 -1      extensions/konqueror/CMakeLists.txt  
 M  +93 -28    extensions/konqueror/kget_linkview.cpp  
 M  +20 -5     extensions/konqueror/kget_linkview.h  
 M  +10 -13    extensions/konqueror/kget_plug_in.cpp  
 M  +0 -1      extensions/konqueror/kget_plug_in.h  
 M  +29 -0     mainwindow.cpp  
 M  +5 -0      mainwindow.h  
 M  +3 -0      org.kde.kget.xml  
 M  +1 -0      ui/kgetui.rc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=798793
Comment 4 FiNeX 2008-04-20 22:16:23 UTC
Great, thanks!
Comment 5 FiNeX 2008-04-23 01:00:04 UTC
well... I've just see the "import links".
There is a problem: I've used a test file with this two entries:

http://kernel.org/pub/linux/kernel/v2.6/linux-2.6.25.tar.bz2
http://kernel.org/pub/linux/kernel/v2.2/linux-2.2.26.tar.bz2


The "import links" dialog show eight entries. Look at the screenshot on next comment.


Moreover the "select all" button allow to select all, but if I want to de-select all I've to manually de-select them.
Comment 6 FiNeX 2008-04-23 01:00:38 UTC
forget to reopen :)
Comment 7 FiNeX 2008-04-23 01:01:15 UTC
Created attachment 24481 [details]
kget import
Comment 8 Javier goday 2008-04-23 09:15:09 UTC
seems that we need to improve the regular expression :)

On Wed, Apr 23, 2008 at 1:01 AM, FiNeX <finex@finex.org> wrote:

[bugs.kde.org quoted mail]
seems that we need to improve the regular expression :)<br><br><div class="gmail_quote">On Wed, Apr 23, 2008 at 1:01 AM, FiNeX &lt;<a href="mailto:finex@finex.org">finex@finex.org</a>&gt; wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">------- You are receiving this mail because: -------<br>
You are the assignee for the bug, or are watching the assignee.<br>
<br>
<a href="http://bugs.kde.org/show_bug.cgi?id=158320" target="_blank">http://bugs.kde.org/show_bug.cgi?id=158320</a><br>
<br>
<br>
<br>
<br>
</div>------- Additional Comments From finex finex org &nbsp;2008-04-23 01:01 -------<br>
Created an attachment (id=24481)<br>
&nbsp;--&gt; (<a href="http://bugs.kde.org/attachment.cgi?id=24481&amp;action=view" target="_blank">http://bugs.kde.org/attachment.cgi?id=24481&amp;action=view</a>)<br>
kget import<br>
<div><div></div><div class="Wj3C7c">_______________________________________________<br>
Kget mailing list<br>
<a href="mailto:Kget@kde.org">Kget@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kget" target="_blank">https://mail.kde.org/mailman/listinfo/kget</a><br>
</div></div></blockquote></div><br>
Comment 9 Javier goday 2008-04-23 09:47:48 UTC
Created attachment 24485 [details]
patch to allow write the regular expression in the configuration

Allow to set regular expression in the configuration, to help find a better one
Comment 10 Urs Wolfer 2008-04-23 20:26:03 UTC
jgoday: I'm not sure if it would be a good idea to commit this patch. The user almost never needs to change this regex. It's probably nice to find the perfect one for you as developer, though.
Comment 11 Javier goday 2008-04-24 10:36:08 UTC
uwolfer: yes, could be, as long as this patch will help to find a better regexp to whoever he want's, without commit it :)
Comment 12 LXj 2008-04-24 19:22:13 UTC
What is the regex currently used? I could try playing with different refex outside of KGet (with grep or my own script)
Comment 13 Urs Wolfer 2008-04-24 20:18:13 UTC
LXj: The current regex looks like this:
static QString REGULAR_EXPRESSION = "(((https?|ftp|gopher)://|(mailto|file|news):)[^’ <>\"]+|(www|web|w3).[-a-z0-9.]+)[^’ .,;<>\":]";

Would be nice if you could find a working one :)
Comment 14 Javier goday 2008-05-01 13:29:40 UTC
SVN commit 802953 by jgoday:

Check if the urls are valid in the linkimporter and linkview (uwolfer's tip)
BUG:158320


 M  +4 -1      core/linkimporter.cpp  
 M  +4 -1      ui/linkview/kget_linkview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=802953