Version: (using KDE 3.5.8) Installed from: Compiled From Sources Next attached patch adds a precise ratio crop feature as suggested by Arnd (Bug 128293 Comment #12).
Created attachment 23652 [details] ratiocrop-precisecrop.patch Changes: - new option to force a precise aspect ratio crop. - reuse code from applyAspectRatio function when drawing a symmetric selection with mouse, thus computeAspectRatio function is no more needed. - few more comments added to code. Arnd, does it work as you thought?
SVN commit 777847 by abaecker: When using the aspect ratio crop, it is now possible to ensure that the aspect ratio is fulfilled exactly. This is done by only allowing those combinations of width/heights which lead to the correct aspect ratio (thanks to Roberto Castagnola who wrote the patch). CCBUGS: 158174 TODO:KDE4PORT M +3 -1 NEWS M +25 -4 imageplugins/coreplugin/ratiocrop/imageeffect_ratiocrop.cpp M +2 -0 imageplugins/coreplugin/ratiocrop/imageeffect_ratiocrop.h M +138 -170 imageplugins/coreplugin/ratiocrop/imageselectionwidget.cpp M +7 -2 imageplugins/coreplugin/ratiocrop/imageselectionwidget.h WebSVN link: http://websvn.kde.org/?view=rev&revision=777847
Roberto, thanls again for this patch... Arnd, this file is not yet closed... Gilles
Arnd, I'm stupid (:=))). It's not yet closed because the code is not yet ported to KDE4... Sorry for the sound (:=))) Gilles
Roberto, everything works perfect in all the cases I checked. Thanks a lot for your patch, it is very much appreciated!! Best wishes, Arnd
SVN commit 785562 by cgilles: digiKam from trunk (KDE4) : Ratio crop tool : backport commit #777847 from KDE3 branch CCBUGS: 158174 M +27 -6 imageeffect_ratiocrop.cpp M +2 -0 imageeffect_ratiocrop.h M +140 -171 imageselectionwidget.cpp M +9 -4 imageselectionwidget.h WebSVN link: http://websvn.kde.org/?view=rev&revision=785562
Roberto, Your patch have been ported to KDE4 implementation. But i recommend to test if all work fine for you. Your patch is huge and i hope to not have forget something (:=))) Thanks in advance Gilles Caulier
Screenshot of Showfoto for KDE4 running Ratio Crop tool using "Desert" color scheme theme: http://digikam3rdparty.free.fr/Screenshots/FullColorThemeSupport/fullcolortheme6.png This rock no ??? Gilles Caulier
> This rock no ??? Yes, it rocks :)
It's a PITA for me to download it with svn at home using 56K modem, and I don't know how to download it at work using windows. Is there any kde4 port snapshot available?
Roberto, Yes, there are daily snapshot created automatically by a script hosted by KDE. Look here : ftp://ftp.kde.org/pub/kde/unstable/snapshots/ Gilles
Gilles, I will hopefully try it next week, thanks.
Code is now backported to KDE4. I close this file.