Bug 157424 - View Mode cannot be changed in the dolphin part inside Konqueror
Summary: View Mode cannot be changed in the dolphin part inside Konqueror
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-08 14:28 UTC by András Manţia
Modified: 2008-02-13 19:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description András Manţia 2008-02-08 14:28:24 UTC
Version:            (using Devel)

When embedded inside Konqueror, the View Mode menu is missing because...Konqueror has one View Mode menu as well to select the kpart used to view the current page/folder. This way the view mode can be changed only using the toolbar buttons, not the menu. This is inconsistent, doesn't follow the style guide and is an accessibility problem.
Comment 1 David Faure 2008-02-13 19:08:02 UTC
SVN commit 774632 by dfaure:

Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library.
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.
BUG: 157424


 M  +1 -30     dolphin/src/dolphinmainwindow.cpp  
 M  +1 -6      dolphin/src/dolphinmainwindow.h  
 M  +14 -26    dolphin/src/dolphinpart.cpp  
 M  +23 -0     dolphin/src/dolphinpart.desktop  
 M  +27 -9     dolphin/src/dolphinpart.h  
 M  +0 -43     dolphin/src/dolphinview.cpp  
 M  +0 -26     dolphin/src/dolphinview.h  
 M  +63 -0     dolphin/src/dolphinviewactionhandler.cpp  
 M  +31 -2     dolphin/src/dolphinviewactionhandler.h  
 M  +0 -1      konqueror/src/konq-simplebrowser.rc  
 M  +0 -79     konqueror/src/konqactions.cpp  
 M  +0 -23     konqueror/src/konqactions.h  
 M  +1 -1      konqueror/src/konqfactory.cpp  
 M  +130 -376  konqueror/src/konqmainwindow.cpp  
 M  +5 -13     konqueror/src/konqmainwindow.h  
 M  +0 -5      konqueror/src/konqueror.kcfg  
 M  +0 -1      konqueror/src/konqueror.rc  
 M  +21 -6     konqueror/src/konqview.cpp  
 M  +13 -3     konqueror/src/konqview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=774632