Bug 157168 - Check return codes everywhere
Summary: Check return codes everywhere
Status: RESOLVED INTENTIONAL
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: 1.9.6
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-04 22:15 UTC by Markus Elfring
Modified: 2008-11-19 18:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Elfring 2008-02-04 22:15:43 UTC
Version:           1.9.6 (using KDE 3.5.8)
Installed from:    SuSE RPMs
OS:                Linux

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "fread" like in the function "KMMsgDict::openFolderIds" and from "fseek" in the function "KMMsgDict::writeFolderIds"?
(Source file "kmmsgdict.cpp")
Comment 1 Thomas McGuire 2008-02-05 14:39:08 UTC
This bugtracker is not for implementation details of the code, it is about user-visible bugs.
Don't write bug reports for implementation details.

I understand that not checking return values could, under very rare circumstances, lead to a bug.

This is unlikely, and no one has experienced this so far.

Furthermore, the whole message dict thing will be replaced by Akonadi.
Comment 2 Markus Elfring 2008-02-05 15:54:59 UTC
Ignored error codes might become noticeable by a user if related system resources were exhausted.
I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?

Will the software "Akonadi" be better in this design aspect?
Comment 3 Thomas McGuire 2008-02-05 16:13:34 UTC
I know what the consequences are.
WONTFIX means that the bug will not be fixed by us. Patches are still welcome. Please do not reopen.

>Will the software "Akonadi" be better in this design aspect? 
I don't know.
Comment 4 Markus Elfring 2008-02-05 17:52:37 UTC
My bug report might affect fundamental design aspects in your
software. I imagine that a consensus will be needed for proper fixes.