Bug 156534 - Support renaming volumes via udisks2
Summary: Support renaming volumes via udisks2
Status: ASSIGNED
Alias: None
Product: frameworks-solid
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords:
: 165893 185987 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-01-24 10:35 UTC by Elias Probst
Modified: 2020-09-30 21:28 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to add setLabel for solid storagevolumes (2.87 KB, patch)
2013-10-29 22:08 UTC, Orion Poplawski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2008-01-24 10:35:58 UTC
Version:            (using Devel)
Installed from:    Compiled sources

kfileplacesview should show more information about each volume, like the volume label (if available) and the usage.

Regarding the volume usage, I did a quick mock-up which I already presented some days ago in #dolphin:
http://eliasprobst.eu/~elias/stuff/screenshots/kde4-issues/dolphin/volume-volume-spacebar.png

Regarding the volume label:
I've already looked for a generic way to change the label of a volume, but it looks like Solid/HAL currently do not provide this or I haven't found it.
Displaying it should be easier - functionality is provided by Solid.
Comment 1 Elias Probst 2008-06-01 14:57:16 UTC
Good news regarding the label support: there's a successor developed by HALs fame of David Zeuthen, which also includes support for reading/setting device/volume labels:
http://hal.freedesktop.org/docs/DeviceKit/
http://lists.freedesktop.org/archives/hal/2008-May/011560.html

I think this would be a good chance to begin supporting DeviceKit in KDE (I don't know, whether they will be incompatible, so that DeviceKit support blocks HAL and whether DeviceKit will provide a HAL-compat module, but as far as I understood, it shouldn't be a problem adding DeviceKit-Disks support to KDE without breaking HAL support.)

The "free space" information in kdelibs for each volume could be retrieved by DeviceKit too.
The good thing about DeviceKit: as far as I know it is designed to be portable (at least portable to other POSIX compatible systems, don't know about Win).

Where does this whole thing go to? Is it now Solid+kdelibs+dolphin?

Regards, Elias P.
Comment 2 Elias Probst 2008-11-29 23:25:33 UTC
The used/free space is now shown for mounted volumes in 4.2 (currently still trunk, thanks a lot for implementing it!) but DeviceKit support is still missing in KDE.
Comment 3 Dario Andres 2009-01-06 13:49:26 UTC
Changed title and reassigning (however I don't know if this is more Solid related)
Comment 4 Elias Probst 2009-02-02 23:33:26 UTC
*** Bug 165893 has been marked as a duplicate of this bug. ***
Comment 5 Christoph Feck 2009-06-27 19:24:49 UTC
*** Bug 185987 has been marked as a duplicate of this bug. ***
Comment 6 Konstantin Nikkari 2013-09-26 07:54:13 UTC
Five years from reported date and still no method to change Devices name in Places tab? Why this is so hard and still can be easily done in Windows and I guess in OSX too?
Comment 7 Elias Probst 2013-09-27 14:53:14 UTC
(In reply to comment #6)
> Five years from reported date and still no method to change Devices name in
> Places tab? Why this is so hard and still can be easily done in Windows and
> I guess in OSX too?

It can also be done easily in KDE/Gnome/whatever nowadays, it just needs someone to implement this.
This bug just serves as external input to developers as idea what they might pick up in case they're interested in working on a new feature, but there's no guarantee such a feature might be ever implemented at all - if you urgently want/need a feature - see what you can do on your own.

Besides that, this is something which needs to be done in Solid first, then it can be picked up by other applications (e.g. Dolphin as suggested above).

As Solid uses 'udisks' to handle disk related stuff,  the label of a volume can be set using 'SetLabel' as documented here: http://udisks.freedesktop.org/docs/latest/gdbus-org.freedesktop.UDisks2.Filesystem.html

AFAIK udisks2 exposes this method only for volumes which allow setting a label.

I'm assigning this now to 'solid' as the UI parts are either implemented or not that important.
Besides that, the title was updated to reflect the changes (HAL → DeviceKit → udisks → udisks2) of the used toolkits throughout the last years.
Comment 8 Orion Poplawski 2013-10-29 22:08:14 UTC
Created attachment 83215 [details]
Patch to add setLabel for solid storagevolumes

Is this anything like the right direction?
Comment 9 Jonathan Riddell 2015-03-11 19:11:35 UTC
This bug is reported on libsolid which is the kdelibs4 version of the solid library.  It is now in maintenance mode.  If you think it should still be fixed in the KDE Frameworks 5 version of solid please move it to or report a bug on frameworks-solid.
Comment 10 Bug Janitor Service 2020-06-16 17:37:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/solid/-/merge_requests/7
Comment 11 Kwon-Young Choi 2020-06-16 17:44:29 UTC
I have made a merge request out of the patch of Orion Poplawski at https://invent.kde.org/frameworks/solid/-/merge_requests/7

Let me know if there is anything to change.