Bug 156295 - Add widget, "generic icon", adds an icon without url
Summary: Add widget, "generic icon", adds an icon without url
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: desktop (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 154956 156334 157132 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-01-21 04:39 UTC by David
Modified: 2008-02-03 11:40 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David 2008-01-21 04:39:02 UTC
Version:           SVN (using Devel)
Installed from:    Compiled sources
Compiler:          4.1.2 
OS:                Linux

When you create a icon plasmoid on desktop, and you click on the button to change its type, you get a SIGSEGV (11) in keditfiletype.

Steps to reproduce:
1.- Open the add widget window (by rightclicking desktop and selecting proper option, or by clicking add widget button in top right corner)
2.- Place a generic icon plasmoid
3.- Open its settings
4.- Click on the tool button to change its type and you'll see the error
(after closing error message of death of keditfiletype, you can repeat step 4 and you'll get same result, never working..)

SVN snapshots:
svn info /usr/portage/distfiles/svn-src/KDE/kdelibs/kdelibs
Path: /usr/portage/distfiles/svn-src/KDE/kdelibs/kdelibs
URL: svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs
Repository Root: svn://anonsvn.kde.org/home/kde
Repository UUID: 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Revision: 763963
Node Kind: directory
Schedule: normal
Last Changed Author: djarvie
Last Changed Rev: 763956
Last Changed Date: 2008-01-20 18:19:26 +0100 (dom, 20 ene 2008)
========================
svn info /usr/portage/distfiles/svn-src/KDE/kdebase/kdebase/
Path: /usr/portage/distfiles/svn-src/KDE/kdebase/kdebase
URL: svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase
Repository Root: svn://anonsvn.kde.org/home/kde
Repository UUID: 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Revision: 763967
Node Kind: directory
Schedule: normal
Last Changed Author: ogoffart
Last Changed Rev: 763953
Last Changed Date: 2008-01-20 18:11:56 +0100 (dom, 20 ene 2008)
Comment 1 Oliver Putz 2008-01-21 05:31:52 UTC
I can confirm this crash with the following backtrace:

Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 0xb60b66d0 (LWP 5718)]
[KCrash handler]
#6  0xb7d54717 in KSycocaEntry::d_func (this=0xbf88a380)
    at /var/tmp/portage/kde-base/kdelibs-9999.4/work/kdelibs-9999.4/kdecore/sycoca/ksycocaentry.h:148
#7  0x0805b90d in MimeTypeData (this=0xbf88a380, mime=@0xbf88a3dc, newItem=64)
    at /var/tmp/portage/kde-base/kdebase-9999.4/work/kdebase-9999.4/apps/konqueror/settings/filetypes/mimetypedata.cpp:50
#8  0x08051a37 in FileTypeDialog::init (this=0xbf88a478, mime=@0xbf88a410, 
    newItem=true)
    at /var/tmp/portage/kde-base/kdebase-9999.4/work/kdebase-9999.4/apps/konqueror/settings/filetypes/keditfiletype.cpp:61
#9  0x08051c98 in FileTypeDialog (this=0xbf88a478, mime=@0xbf88a564, 
    newItem=true)
    at /var/tmp/portage/kde-base/kdebase-9999.4/work/kdebase-9999.4/apps/konqueror/settings/filetypes/keditfiletype.cpp:55
#10 0x0805265a in main (argc=4, argv=0xbf88a664)
    at /var/tmp/portage/kde-base/kdebase-9999.4/work/kdebase-9999.4/apps/konqueror/settings/filetypes/keditfiletype.cpp:169
#11 0xb63befdc in __libc_start_main (main=0x8051cd0 <main>, argc=4, 
    ubp_av=0xbf88a664, init=0x8063710 <__libc_csu_init>, 
    fini=0x8063700 <__libc_csu_fini>, rtld_fini=0xb7fa3100 <_dl_fini>, 
    stack_end=0xbf88a65c) at libc-start.c:229
#12 0x080516e1 in _start ()
#0  0xffffe410 in __kernel_vsyscall ()
Comment 2 David Faure 2008-01-21 12:31:12 UTC
SVN commit 764296 by dfaure:

Don't crash when called with '*' as argument. But the real question is, why is plasma creating a file with a mimetype of "*"?
CCBUG: 156295


 M  +6 -2      keditfiletype.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=764296
Comment 3 David Faure 2008-01-21 13:39:20 UTC
The problem is that m_url is empty, in IconApplet::showConfigurationInterface().
Comment 4 David Faure 2008-01-21 13:43:59 UTC
Maybe this applet should simply not appear in "Add Widgets"?
Comment 5 David 2008-01-22 06:17:06 UTC
David Faure, I agree with you, I think create icon could be in right click menu, as always..
Comment 6 David Faure 2008-01-22 17:26:27 UTC
*** Bug 156334 has been marked as a duplicate of this bug. ***
Comment 7 David Faure 2008-01-22 17:26:55 UTC
*** Bug 154956 has been marked as a duplicate of this bug. ***
Comment 8 Aaron J. Seigo 2008-01-24 22:02:46 UTC
@David (!Faure): while it could be in the right click menu, it really doesn't make much sense to do so given where we are headed with desktop icons.
Comment 9 Aaron J. Seigo 2008-01-24 22:05:29 UTC
SVN commit 765906 by aseigo:

don't show the icon applet in the add widgets dialog for now as it leaves one with an empty hull of an icon, which leads to various annoyances for people apparently. if/when the Icon applet sports more useful features in a default setting, we can reinstate it's visibility.
BUG:156295


 M  +1 -0      plasma-applet-icon.desktop  


WebSVN link: http://websvn.kde.org/?view=rev&revision=765906
Comment 10 Pino Toscano 2008-02-03 11:40:56 UTC
*** Bug 157132 has been marked as a duplicate of this bug. ***