Bug 155853 - Toolbars in the Contact list don't remember their position
Summary: Toolbars in the Contact list don't remember their position
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: Main Application (show other bugs)
Version: 0.50.0
Platform: Mandriva RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-15 20:13 UTC by David
Modified: 2008-12-05 18:18 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David 2008-01-15 20:13:12 UTC
Version:            (using KDE KDE 4.0.0)
Installed from:    Mandriva RPMs
OS:                Linux

I think the short description says enough.
The toolbars are placed the default way after quitting and then running Kopete again.
Comment 1 Matt Rogers 2008-01-16 02:22:17 UTC
How do we reproduce this?
Comment 2 David 2008-01-16 17:12:21 UTC
-Move a toolbar in the contact list somewhere else.
-Quit Kopete.
-Run Kopete again.
Comment 3 Charles Connell 2008-01-17 01:52:19 UTC
I think that this is because we don't do the normal saveState and loadState in KopeteWindow, but we do bits of info like the geometry and visibility separately, and toolbar positions certainly are not stored.
Comment 4 Ruud Koolen 2008-07-07 15:47:00 UTC
Confirmed in kde4 (Kopete 0.50.80).
Comment 5 Marcelo Vivan Borro 2008-08-14 22:57:09 UTC
I have this problem on chat windows.  Every time I open a new chat window the toolbars are on the right.
Is this the same bug?
Comment 6 Marcelo Vivan Borro 2008-08-14 22:59:10 UTC
Forgot to mention Kopete version: 0.60.1  on KDE 4.1 - Opensuse 11.0
Comment 7 Sebastian Vahl 2008-11-11 12:17:28 UTC
Same here with kopete 0.60.2 form kdenetwork-4.1.2 on Fedora 9/10.
The orientation is saved to ~/.kde/share/config/kopeterc but not honored:

[General Options][Toolbar editGlobalIdentityBar]
Index=1
ToolButtonStyle=TextUnderIcon

[General Options][Toolbar mainToolBar]
Index=0
ToolButtonStyle=IconOnly

[General Options][Toolbar quickSearchBar]
Hidden=true
Index=2
ToolButtonStyle=TextUnderIcon

[General Options Toolbar editGlobalIdentityBar]
IconText=IconOnly
Index=1

[General Options Toolbar mainToolBar]
Index=0
Offset=2
Position=Left

[General Options Toolbar quickSearchBar]
Hidden=true
IconText=IconOnly
Index=0
NewLine=true
Comment 8 S. Burmeister 2008-11-20 16:56:34 UTC
Would it be possible to workaround this bug by changing the default position of the toolbars? IMO the current default does not make sense, since in combination with the default width of the window, neither the main toolbar nor the search toolbar are usable.

So I suggest to place the search toolbar beneath the main toolbar by default.
Comment 9 Will Stephenson 2008-12-05 18:05:25 UTC
SVN commit 892985 by wstephens:

Prior to KDE 4, Kopete was already using [General Options]->State for
storing whether the mainwindow was visible.  'State' was adopted by
QMainWindow for encoding its toolbar positions in Qt4, and by chance
this field is located by in the KConfigGroup passed to
KMainWindow::saveMainWindowSettings(), so QMainWindow's State was
overwritten by Kopete and toolbar locations were lost.
BUG:155853


 M  +4 -4      kopetewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=892985
Comment 10 Will Stephenson 2008-12-05 18:12:33 UTC
SVN commit 892988 by wstephens:

Backport r892985 (Fix kopete toolbar location save/restore)
CCBUG:155853


 M  +4 -4      kopetewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=892988
Comment 11 Will Stephenson 2008-12-05 18:18:47 UTC
Fixed in openSUSE KDE:KDE4:Factory:Desktop and openSUSE 11.1 (downstream BR: https://bugzilla.novell.com/show_bug.cgi?id=440801)