Bug 155480 - Image applet frame doesn't scale correctly
Summary: Image applet frame doesn't scale correctly
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-frame (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-12 13:03 UTC by Dorian Vasco
Modified: 2008-01-13 11:07 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
look at the border of the plasmoid image (136.15 KB, image/jpeg)
2008-01-12 13:04 UTC, Dorian Vasco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dorian Vasco 2008-01-12 13:03:43 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

Some pieces of the half-transparent border of the ImagePlasmoid are a bit confused, if I scale the image too large (about 800x800px).
Comment 1 Dorian Vasco 2008-01-12 13:04:51 UTC
Created attachment 22955 [details]
look at the border of the plasmoid image
Comment 2 Anne-Marie Mahfouf 2008-01-12 13:47:07 UTC
It's in the rounded corners code, I'll investigate more!
Comment 3 Anne-Marie Mahfouf 2008-01-12 22:45:46 UTC
Proposed patch against extragear/plasma/applets/frame, can you test please? 
Index: frame.cpp
===================================================================
--- frame.cpp   (revision 760529)
+++ frame.cpp   (working copy)
@@ -331,8 +331,7 @@
         p->setBrush(Qt::NoBrush);
         for (int i = 0; i <= m_swOutline; i+=1) {
             p->setOpacity(0.7*exp(-(i/(double)(m_swOutline/3))));
-            QPainterPath tr; //I use this because p.drawRoundRect is different(and ugly)
-            tr.addRoundRect(shadowRect, swRoundness+i);
+            QPainterPath tr=Plasma::roundedRectangle(shadowRect, swRoundness+i);
             p->drawPath(tr);
             shadowRect.adjust(-1, -1, +1, +1);
         }
Comment 4 Aaron J. Seigo 2008-01-13 00:35:05 UTC
it probably should be using the Plasma method there anyways; if it works for you at larger sizes then i'd say commit =)
Comment 5 Anne-Marie Mahfouf 2008-01-13 11:01:16 UTC
SVN commit 760679 by annma:

Make shadow behaves better at big sizes
CCBUG=155480


 M  +1 -2      frame.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=760679
Comment 6 Anne-Marie Mahfouf 2008-01-13 11:07:29 UTC
closing as there's no extragear/plasma in 4.0 branch so no backport needed ;)