Bug 155368 - messages quoting extremely needed
Summary: messages quoting extremely needed
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-10 02:56 UTC by Roman Snitko
Modified: 2008-02-12 02:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch for history plugin (2.64 KB, patch)
2008-01-10 23:08 UTC, Alexander Rieder
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Snitko 2008-01-10 02:56:29 UTC
Version:           0.12.7 (using KDE KDE 3.5.8)
Installed from:    SuSE RPMs
OS:                Linux

What would be really useful is a simple messages quoting. Say, if I want to quote my friend's previous message, I just click the button and it appears in the typing area like this:

>Hey, bubba. I thought you could write this plugin yourself!

What could also be good is to be able to quote not only previous messages, but all of them during current chat-session, when each quote-button clicking shows the older message. It would also be useful to quote a selected part of the message.

I asked on the kde-forum: http://www.kde-forum.org/thread.php?threadid=18028
Seems like no one knows about anything like that.
Comment 1 Charles Connell 2008-01-10 02:59:19 UTC
This seems fairly easy to implement
Comment 2 Roman Snitko 2008-01-10 03:06:31 UTC
Well, I guess, if someone does this, a lot of people will be truly happy.
Comment 3 Alexander Rieder 2008-01-10 23:08:51 UTC
Created attachment 22948 [details]
Patch for history plugin

I've created a quick and simple patch to add the quoting functionality. I've
modified the history plugin, instead of writing a new one, because it seems
pretty hard to access the last messages from within a plugin. At the moment it
only quotes the last message, but adding functionality shouldn't be too hard
Comment 4 Roman Snitko 2008-01-10 23:29:21 UTC
Do you I have to mark as 'resolved' now, or just leave it?
Comment 5 Matt Rogers 2008-01-11 02:38:45 UTC
we have to commit the feature to subversion first
Comment 6 Charles Connell 2008-02-12 02:35:10 UTC
SVN commit 773908 by cconnell:

Allow for quoting of messages through history plugin
This exposed a bug in ChatTextEditPart, which is also fixed in this commit
FEATURE:155368


 M  +4 -1      kopete/chatwindow/chattexteditpart.cpp  
 M  +2 -0      plugins/history/historychatui.rc  
 M  +70 -40    plugins/history/historyguiclient.cpp  
 M  +1 -0      plugins/history/historyguiclient.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=773908