Bug 155072 - Support for files attached to an annotation
Summary: Support for files attached to an annotation
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-04 13:04 UTC by Tobias Burnus
Modified: 2008-10-12 01:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
PDF file with embedded text file (24.42 KB, application/pdf)
2008-01-04 13:23 UTC, Tobias Burnus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Burnus 2008-01-04 13:04:42 UTC
Version:            (using KDE KDE 3.97.0)
Installed from:    SuSE RPMs

I cannot find anywhere the option to save embedded files; nor can I find an matching bug report - assuming that bug 139144 (at least it is different from the example of bug 136574 of which the former has been marked a duplicate).

Poppler supports embedded files according to the change log.
  poppler-0.5.1.tar.gz (Wed Feb 28, 2006)
          - Support for embedded files.

In Adobe Reader, one has an annotation which is linked to the file; double clicking shows a open-file dialog (1 Open; 2 always open this file type; 3 always deny opening this filetype); right click allows to open and save that file.
Additionally, there is a button which allows to to show all attached files (incl. the page number where it has been embedded).

It would be great if Okular could support the something similar.
Comment 1 Pino Toscano 2008-01-04 13:11:01 UTC
The closed bug you link is really a dupe, as it requests for videos.

Okular supports the attachments of a document, but not to annotations.
You are referring to the second kind, thus I properly renamed this bug report.

Furhermore, it isn't a PDF-specific wish as it needs work in the core and in the GUI.
Comment 2 Tobias Burnus 2008-01-04 13:23:50 UTC
Created attachment 22828 [details]
PDF file with embedded text file

Test case.
Comment 3 Tobias Burnus 2008-01-04 14:12:48 UTC
Another example: http://www.microtype.com/showcase/EmbedFiles.pdf

Note: In that example two of the four attached files are attached to the document only; i.e. they only show up in the attached-files tab and have no associated annotation. (I therefore believe the changed bug summary is misleading.)
Comment 4 Pino Toscano 2008-01-04 14:28:16 UTC
I just checked again (to be sure) with acroread.
In the document you attached, there is one "file attachment" annotation that neither Poppler or Okular support.
While, in the document you link there are four attachments: two of them are document attachments (and Okular shows them properly), while the other two are again two "file attachment" annotations.

So my change to the bug summary is correct, so far: Okular (but Poppler too) does not support "file attachment" annotations.
Comment 5 Pino Toscano 2008-04-13 18:34:59 UTC
SVN commit 796467 by pino:

Add support in the Okular core for File Attachment annotations.
(Although, they cannot be (de)serialized to XML.)

CCBUG: 155072


 M  +85 -0     annotations.cpp  
 M  +38 -0     annotations.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=796467
Comment 6 Pino Toscano 2008-04-13 18:41:13 UTC
SVN commit 796468 by pino:

Ad-hoc conversion from a Poppler File Attachment annotation to an Okular one.
It requires the new annotation type I introduced about 10 minutes ago in the development version of Poppler.

CCBUG: 155072


 M  +18 -0     annots.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=796468
Comment 7 Pino Toscano 2008-04-15 00:41:41 UTC
SVN commit 797113 by pino:

Offers the possibility to save the attached file when right clicking on a file attachment annotation.

CCBUG: 155072


 M  +14 -0     annotationpopup.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=797113
Comment 8 Pino Toscano 2008-10-12 01:40:11 UTC
Thanks to the Poppler library version 0.10 released two days ago, now Okular 4.1 and greater is able to recognize file attachment annotations, to see the details of their attachments and to save them, so the general support for them is done (and the wish can be considered solved).
Okular provides just the possibility to save an attached file and to view its details (name, and description and size if present), so any additional actions (if needed) should be requested in new wishes.