Bug 155007 - two clear buttons maybe present at the same time in location bar
Summary: two clear buttons maybe present at the same time in location bar
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 4.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-03 08:15 UTC by Germain Garand
Modified: 2008-01-04 00:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
screen capture showing the issue (4.56 KB, image/png)
2008-01-03 08:16 UTC, Germain Garand 		Details
patch for review (2.01 KB, patch)
2008-01-03 08:21 UTC, Germain Garand 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Germain Garand 2008-01-03 08:15:12 UTC 
Version:           4.0 (using KDE Devel)
Installed from:    Compiled sources

the clear button that appears inside the konqueror address bar
may also be added to the location bar itself as a separate tool button (see e.g. "Simple Browser" profile), resulting in an aesthetically and functionally unpleasing redundancy.

What should happen, is that when a separate clear button is present in the location bar, the clear button incorporated
in the address bar should be disabled.
Comment 1 Germain Garand 2008-01-03 08:16:38 UTC 
Created attachment 22818 [details]
screen capture showing the issue
Comment 2 Germain Garand 2008-01-03 08:21:26 UTC 
Created attachment 22819 [details]
patch for review
Comment 3 Germain Garand 2008-01-04 00:43:48 UTC 
SVN commit 757009 by ggarand:

disable kcombobox's internal clear icon when it's already present in the location toolbar 
as a tool button.

reviewed by Michael Pyne

BUG: 155007


 M  +22 -0     konqmainwindow.cpp  
 M  +1 -0      konqmainwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=757009