Bug 154990 - endian fix for audiocd on NetBSD, possibly others
Summary: endian fix for audiocd on NetBSD, possibly others
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: audiocd (show other bugs)
Version: unspecified
Platform: NetBSD pkgsrc NetBSD
: NOR normal
Target Milestone: ---
Assignee: icefox
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-02 21:12 UTC by Mark Davies
Modified: 2008-01-05 21:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
NetBSD endian patch (429 bytes, patch)
2008-01-02 21:13 UTC, Mark Davies
Details
additional patch to what was committed (498 bytes, patch)
2008-01-02 23:44 UTC, Mark Davies
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Davies 2008-01-02 21:12:34 UTC
Version:            (using KDE KDE 3.97.0)
Installed from:    NetBSD pkgsrc
OS:                NetBSD

NetBSD needs include of <machine/endian.h> to use BYTE_ORDER defines in kioslave/audiocd/plugins/lame/encoderlame.cpp.

patch follows.
Comment 1 Mark Davies 2008-01-02 21:13:33 UTC
Created attachment 22808 [details]
NetBSD endian patch
Comment 2 Urs Wolfer 2008-01-02 23:10:44 UTC
SVN commit 756193 by uwolfer:

endian fix for audiocd on NetBSD
Initial patch by Mark Davies.
BUG: 154990

 M  +6 -0      encoderlame.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=756193
Comment 3 Mark Davies 2008-01-02 23:44:31 UTC
Created attachment 22811 [details]
additional patch to what was committed

Hadn't noticed the <sys/endian.h> change post RC2. So the attached patch tweaks
what just got committed to also handle that.
Comment 4 Urs Wolfer 2008-01-05 21:10:19 UTC
SVN commit 757750 by uwolfer:

Additional fix for NetBSD.
Patch by Mark Davies.
CCBUG:154990

 M  +4 -2      encoderlame.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=757750