Bug 154961 - Journal date grid has dates with Calendar entries bold.
Summary: Journal date grid has dates with Calendar entries bold.
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: SVN trunk (KDE 4)
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2008-01-02 09:32 UTC by Dotan Cohen
Modified: 2009-03-23 02:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2008-01-02 09:32:56 UTC
Version:           1.2.5 (using KDE KDE 3.5.8)
Installed from:    Ubuntu Packages

In Kontact, the Journal tab has the dates on which Kalander events are scheduled in bold. Furthermore, there is no way to distinguish which dates have Journal entries. The bold dates should be for dates with Journal entries, not dates with Kalander entries, as it is now.
Comment 1 Michael Leupold 2008-09-28 16:30:20 UTC
Still reproducible in trunk r865573. I don't see a way to figure out which days have journal entries.
Comment 2 Sergio Martins 2009-03-03 04:43:37 UTC
Right, the day matrix only emboldens days which have events, I plan to fix this, but not too soon.
Comment 3 Sergio Martins 2009-03-23 02:22:25 UTC
SVN commit 942964 by smartins:

Added 2 options to config (Views->Date Navigator) so users can choose whether to highlight to-dos
and journals in Todo and Journal View.

I was changing kodaymatrix so it updates it's highlight settings when config changes, but that's
too problematic, it doesn't know which view is selected.

So I created a BaseView::getHighlightMode() that's responsible for knowing what the highlight logic should be,
this way we don't have the logic spread in date navigator and all over koviewmanager.

e.g: If you want to highlight both to-dos and events when in Todo View, just go to TodoView::getHighlightMode()
and change it, no need to change code in date navigator.

DO-NOT-BACKPORT:

BUG: 154961


 M  +20 -1     calendarview.cpp  
 M  +7 -1      calendarview.h  
 M  +8 -0      interfaces/korganizer/baseview.cpp  
 M  +16 -0     interfaces/korganizer/baseview.h  
 M  +40 -10    kodaymatrix.cpp  
 M  +4 -1      kodaymatrix.h  
 M  +2 -0      koprefsdialog.cpp  
 M  +14 -2     korganizer.kcfg  
 M  +1 -11     koviewmanager.cpp  
 M  +10 -0     views/journalview/kojournalview.cpp  
 M  +5 -0      views/journalview/kojournalview.h  
 M  +8 -0      views/todoview/kotodoview.cpp  
 M  +5 -0      views/todoview/kotodoview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=942964