Bug 154840 - BiDi issue in KDE window titles - multiple windows having title foo, foo <n>
Summary: BiDi issue in KDE window titles - multiple windows having title foo, foo <n>
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-30 06:45 UTC by lɛʁi לערי ריינהארט
Modified: 2008-08-13 19:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screen dump · « KDE 3.5.5 » · BiDi issue in Konqueror window titles · 01.jpg (206.99 KB, image/jpeg)
2007-12-30 06:47 UTC, lɛʁi לערי ריינהארט
Details
screen dump · « KDE 3.5.5 » · BiDi issue in FireFox window titles · 01.jpg (201.37 KB, image/jpeg)
2007-12-30 06:51 UTC, lɛʁi לערי ריינהארט
Details
The screen after the fix (600.10 KB, image/png)
2008-08-13 18:27 UTC, Diego Iastrubni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lɛʁi לערי ריינהארט 2007-12-30 06:45:05 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    I Don't Know
OS:                Linux

I will add two scrren dumps in order to understand this bug
Comment 1 lɛʁi לערי ריינהארט 2007-12-30 06:47:43 UTC
Created attachment 22770 [details]
screen dump · « KDE 3.5.5 » · BiDi issue in Konqueror window titles · 01.jpg

either the « < » character or the « > » character are shown at the wrong
place
Comment 2 lɛʁi לערי ריינהארט 2007-12-30 06:51:09 UTC
Created attachment 22771 [details]
screen dump · « KDE 3.5.5 » · BiDi issue in FireFox window titles · 01.jpg

either the « < » character or the « > » character are shown at the wrong
place

Please see also
https://bugzilla.mozilla.org/show_bug.cgi?id=406891
Bug Bugzilla@Mozilla 406891 – BiDi problem in « Mozilla Firefox <n> »
suffix of the window titles
Comment 3 lɛʁi לערי ריינהארט 2008-01-02 22:21:00 UTC
Diego Iastrubni can you please « CONFIRM » this bug / report ?

Thanks in advance Reinhardt
lɛʁi לערי ריינהארט
Comment 4 Diego Iastrubni 2008-08-12 22:45:49 UTC
I am not sure the problem is in kwin... I mean, it's the application's fault it send "broken" text to be displayed. IMHO the problem are the applications.

Who handles the situation in which 2 windows have the same title? is that kwin adding "(%n)"? 

sorry for the long delay ;-)
Comment 5 Lubos Lunak 2008-08-13 14:09:39 UTC
The numbering of windows with same titlebar text is done by KWin, specifically in Client::setCaption() in kdebase/workspace/kwin/client.cpp . If the code is not right for bidi, I have no idea how it should be fixed.
Comment 6 Diego Iastrubni 2008-08-13 16:17:39 UTC
oh... in that case, the fix is quite simple: if string is RTL, to the end of 
the string add "&LRM;". 

It should not be that hard to hack something, and it will have no effect on 
LTR titles. Whats the policy for commiting this into trunk right now? "commit 
and wait for someone to shout" or something more educated like personal 
emails/mailing lists?
Comment 7 Lubos Lunak 2008-08-13 16:26:40 UTC
Please simply commit the fix if you have it.
Comment 8 Diego Iastrubni 2008-08-13 18:24:21 UTC
This is my proposed patch:
simply add LRM to the end of each line. In RTL it will fix the issue, and in LTR it will do nothing.
Comment 9 Diego Iastrubni 2008-08-13 18:27:13 UTC
Created attachment 26838 [details]
The screen after the fix
Comment 10 Diego Iastrubni 2008-08-13 19:31:40 UTC
Stupid bugzilla... well, this was closed in r 846529 :
http://websvn.kde.org/trunk/KDE/kdebase/workspace/kwin/client.cpp?r1=845772&r2=846529