Bug 154829 - inpainting tool doesn't use greycstoration threads
Summary: inpainting tool doesn't use greycstoration threads
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-GmicQt (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-29 20:16 UTC by Lynda Metref
Modified: 2023-03-23 09:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.8.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lynda Metref 2007-12-29 20:16:21 UTC
Version:            (using KDE KDE 3.5.8)
Installed from:    Ubuntu Packages
OS:                Linux

The inpainting plugin in Digikam uses the greycstoration algorithm. This algo supports multithreading but when running it through Digikam, it only uses one CPU. I compared the behaviours of Digikam 0.9.2 and greycstoration 2.5.2: only the latter uses more than one CPU.

Expected behaviour: spawn one thread per CPU.
Comment 1 caulier.gilles 2007-12-31 09:50:49 UTC
Lynda,

Witch digiKam version you use ?

Gilles Caulier
Comment 2 Lynda Metref 2007-12-31 13:45:28 UTC
0.9.2-final from Ubuntu gutsy repository
Comment 3 caulier.gilles 2007-12-31 14:12:27 UTC
OK. 

This is fixed on new digiKam 0.9.3. For indeep problem in CImg library comming with 0.9.2, multithreading has not been used.

With 0.9.3, 2 separate CImg thread are used. Cimg library have been updated of course...

Gilles

Comment 4 Gerhard Kulzer 2008-01-01 14:23:03 UTC
Gilles, 
Restauration and Resize using Greystoration work fine with 2 threads at 100% CPU. Inpainting launches 2 threads as well, but the combined load never exceeds 50%. It seems the threads exclude each other mutually, one goes up, the other down and vise-versa.

Gerhard
Comment 5 caulier.gilles 2017-09-05 05:10:50 UTC
With 5.8.0, in-painting image editor tool was been replaced by a Clone tool.

More details here : 

https://community.kde.org/GSoC/2017/StatusReports/shazaismailkaoud

Gilles Caulier